ARMmbed/mbedtls
1
0
Fork 0
mirror of https://github.com/ARMmbed/mbedtls.git synced 2025-05-10 00:49:04 +08:00
Code Issues Releases Wiki Activity

Remove volatile from declaration

Browse Source 
Use of volatile is more an internal implementation detail (ensuring
const-time) than part of the contract (the caller doesn't care about
volatile as such).

Signed-off-by: Janos Follath <janos.follath@arm.com>
This commit is contained in:
Janos Follath 2024-03-11 10:03:05 +00:00
parent d6df0a5dac
commit adb9d2d822
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
library/bignum_core.c
View File

@ -856,13 +856,14 @@ mbedtls_mpi_uint mbedtls_mpi_core_sub_int(mbedtls_mpi_uint *X,
return c; return c;
} }
mbedtls_ct_condition_t mbedtls_mpi_core_check_zero_ct(volatile const mbedtls_mpi_uint *A, mbedtls_ct_condition_t mbedtls_mpi_core_check_zero_ct(const mbedtls_mpi_uint *A,
size_t limbs) size_t limbs)
{ {
volatile const mbedtls_mpi_uint* force_read_A = A;
mbedtls_mpi_uint bits = 0; mbedtls_mpi_uint bits = 0;
for (size_t i = 0; i < limbs; i++) { for (size_t i = 0; i < limbs; i++) {
bits |= A[i]; bits |= force_read_A[i];
} }
return mbedtls_ct_bool(bits); return mbedtls_ct_bool(bits);

2
library/bignum_core.h
View File

@ -665,7 +665,7 @@ mbedtls_mpi_uint mbedtls_mpi_core_sub_int(mbedtls_mpi_uint *X,
* \return MBEDTLS_CT_FALSE if `A == 0` * \return MBEDTLS_CT_FALSE if `A == 0`
* MBEDTLS_CT_TRUE if `A != 0`. * MBEDTLS_CT_TRUE if `A != 0`.
*/ */
mbedtls_ct_condition_t mbedtls_mpi_core_check_zero_ct(volatile const mbedtls_mpi_uint *A, mbedtls_ct_condition_t mbedtls_mpi_core_check_zero_ct(const mbedtls_mpi_uint *A,
size_t limbs); size_t limbs);
/** /**