From ccd738b85381b7cf42a5ec356a8249ce6755859b Mon Sep 17 00:00:00 2001 From: Xiaofei Bai Date: Wed, 3 Nov 2021 07:12:31 +0000 Subject: [PATCH] Add git rev-parse options Signed-off-by: Xiaofei Bai --- scripts/code_size_compare.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/scripts/code_size_compare.py b/scripts/code_size_compare.py index 898aaf9f38..85393d031c 100755 --- a/scripts/code_size_compare.py +++ b/scripts/code_size_compare.py @@ -58,8 +58,8 @@ class CodeSizeComparison: @staticmethod def validate_revision(revision): - result = subprocess.run(["git", "rev-parse", "--verify", revision], - check=False, stdout=subprocess.PIPE) + result = subprocess.check_output(["git", "rev-parse", "--verify", + revision + "^{commit}"], shell=False) return result def _create_git_worktree(self, revision): @@ -208,15 +208,11 @@ def main(): parser.exit() validate_res = CodeSizeComparison.validate_revision(comp_args.old_rev) - if validate_res.returncode != 0: - sys.exit(validate_res.returncode) - old_revision = validate_res.stdout.decode().replace("\n", "") + old_revision = validate_res.decode().replace("\n", "") if comp_args.new_rev is not None: validate_res = CodeSizeComparison.validate_revision(comp_args.new_rev) - if validate_res.returncode != 0: - sys.exit(validate_res.returncode) - new_revision = validate_res.stdout.decode().replace("\n", "") + new_revision = validate_res.decode().replace("\n", "") else: new_revision = "current"