diff --git a/include/mbedtls/mbedtls_config.h b/include/mbedtls/mbedtls_config.h index 1c631b5267..996d9f6a57 100644 --- a/include/mbedtls/mbedtls_config.h +++ b/include/mbedtls/mbedtls_config.h @@ -2181,9 +2181,10 @@ * Enable the debug functions. * * Module: library/debug.c - * Caller: library/ssl_cli.c - * library/ssl_srv.c + * Caller: library/ssl_msg.c * library/ssl_tls.c + * library/ssl_tls12_*.c + * library/ssl_tls13_*.c * * This module provides debugging functions. */ @@ -2211,8 +2212,9 @@ * Enable the Diffie-Hellman-Merkle module. * * Module: library/dhm.c - * Caller: library/ssl_cli.c - * library/ssl_srv.c + * Caller: library/ssl_tls.c + * library/ssl*_client.c + * library/ssl*_server.c * * This module is used by the following key exchanges: * DHE-RSA, DHE-PSK @@ -2232,8 +2234,10 @@ * Enable the elliptic curve Diffie-Hellman library. * * Module: library/ecdh.c - * Caller: library/ssl_cli.c - * library/ssl_srv.c + * Caller: library/psa_crypto.c + * library/ssl_tls.c + * library/ssl*_client.c + * library/ssl*_server.c * * This module is used by the following key exchanges: * ECDHE-ECDSA, ECDHE-RSA, DHE-PSK @@ -2519,9 +2523,11 @@ * Enable the generic public (asymetric) key layer. * * Module: library/pk.c - * Caller: library/ssl_tls.c - * library/ssl_cli.c - * library/ssl_srv.c + * Caller: library/psa_crypto_rsa.c + * library/ssl_tls.c + * library/ssl*_client.c + * library/ssl*_server.c + * library/x509.c * * Requires: MBEDTLS_RSA_C or MBEDTLS_ECP_C * @@ -2689,10 +2695,11 @@ * * Module: library/rsa.c * library/rsa_alt_helpers.c - * Caller: library/ssl_cli.c - * library/ssl_srv.c + * Caller: library/pk.c + * library/psa_crypto.c * library/ssl_tls.c - * library/x509.c + * library/ssl*_client.c + * library/ssl*_server.c * * This module is used by the following key exchanges: * RSA, DHE-RSA, ECDHE-RSA, RSA-PSK @@ -2708,10 +2715,7 @@ * * Module: library/sha1.c * Caller: library/md.c - * library/ssl_cli.c - * library/ssl_srv.c - * library/ssl_tls.c - * library/x509write_crt.c + * library/psa_crypto_hash.c * * This module is required for TLS 1.2 depending on the handshake parameters, * and for SHA1-signed certificates. @@ -2750,9 +2754,9 @@ * Module: library/sha256.c * Caller: library/entropy.c * library/md.c - * library/ssl_cli.c - * library/ssl_srv.c * library/ssl_tls.c + * library/ssl*_client.c + * library/ssl*_server.c * * This module adds support for SHA-256. * This module is required for the SSL/TLS 1.2 PRF function. @@ -2818,8 +2822,10 @@ * * Module: library/sha512.c * Caller: library/md.c - * library/ssl_cli.c - * library/ssl_srv.c + * library/psa_crypto_hash.c + * library/ssl_tls.c + * library/ssl*_client.c + * library/ssl*_server.c * * Comment to disable SHA-384 */ @@ -2879,7 +2885,7 @@ * * Enable the SSL/TLS client code. * - * Module: library/ssl_cli.c + * Module: library/ssl*_client.c * Caller: * * Requires: MBEDTLS_SSL_TLS_C @@ -2893,7 +2899,7 @@ * * Enable the SSL/TLS server code. * - * Module: library/ssl_srv.c + * Module: library/ssl*_server.c * Caller: * * Requires: MBEDTLS_SSL_TLS_C @@ -2908,8 +2914,8 @@ * Enable the generic SSL/TLS code. * * Module: library/ssl_tls.c - * Caller: library/ssl_cli.c - * library/ssl_srv.c + * Caller: library/ssl*_client.c + * library/ssl*_server.c * * Requires: MBEDTLS_CIPHER_C, MBEDTLS_MD_C * and at least one of the MBEDTLS_SSL_PROTO_XXX defines @@ -2994,9 +3000,9 @@ * Enable X.509 certificate parsing. * * Module: library/x509_crt.c - * Caller: library/ssl_cli.c - * library/ssl_srv.c - * library/ssl_tls.c + * Caller: library/ssl_tls.c + * library/ssl*_client.c + * library/ssl*_server.c * * Requires: MBEDTLS_X509_USE_C * diff --git a/include/mbedtls/ssl.h b/include/mbedtls/ssl.h index b819bbad8f..a16c8e6f34 100644 --- a/include/mbedtls/ssl.h +++ b/include/mbedtls/ssl.h @@ -41,9 +41,8 @@ #endif /* Adding guard for MBEDTLS_ECDSA_C to ensure no compile errors due - * to guards also being in ssl_srv.c and ssl_cli.c. There is a gap - * in functionality that access to ecdh_ctx structure is needed for - * MBEDTLS_ECDSA_C which does not seem correct. + * to guards in TLS code. There is a gap in functionality that access to + * ecdh_ctx structure is needed for MBEDTLS_ECDSA_C which does not seem correct. */ #if defined(MBEDTLS_ECDH_C) || defined(MBEDTLS_ECDSA_C) #include "mbedtls/ecdh.h" diff --git a/library/CMakeLists.txt b/library/CMakeLists.txt index ddede03901..6c3d7fdb49 100644 --- a/library/CMakeLists.txt +++ b/library/CMakeLists.txt @@ -99,12 +99,12 @@ set(src_tls net_sockets.c ssl_cache.c ssl_ciphersuites.c - ssl_cli.c ssl_cookie.c ssl_msg.c - ssl_srv.c ssl_ticket.c ssl_tls.c + ssl_tls12_client.c + ssl_tls12_server.c ssl_tls13_keys.c ssl_tls13_server.c ssl_tls13_client.c diff --git a/library/Makefile b/library/Makefile index e9c0a11744..d49d20cbcb 100644 --- a/library/Makefile +++ b/library/Makefile @@ -168,12 +168,12 @@ OBJS_TLS= \ net_sockets.o \ ssl_cache.o \ ssl_ciphersuites.o \ - ssl_cli.o \ ssl_cookie.o \ ssl_msg.o \ - ssl_srv.o \ ssl_ticket.o \ ssl_tls.o \ + ssl_tls12_client.o \ + ssl_tls12_server.o \ ssl_tls13_keys.o \ ssl_tls13_client.o \ ssl_tls13_server.o \ diff --git a/library/ssl_misc.h b/library/ssl_misc.h index 42563921eb..7b4311f218 100644 --- a/library/ssl_misc.h +++ b/library/ssl_misc.h @@ -623,9 +623,9 @@ struct mbedtls_ssl_handshake_params #endif /* Adding guard for MBEDTLS_ECDSA_C to ensure no compile errors due - * to guards also being in ssl_srv.c and ssl_cli.c. There is a gap - * in functionality that access to ecdh_ctx structure is needed for - * MBEDTLS_ECDSA_C which does not seem correct. + * to guards in client and server code. There is a gap in functionality that + * access to ecdh_ctx structure is needed for MBEDTLS_ECDSA_C which does not + * seem correct. */ #if defined(MBEDTLS_ECDH_C) || defined(MBEDTLS_ECDSA_C) mbedtls_ecdh_context ecdh_ctx; /*!< ECDH key exchange */ diff --git a/library/ssl_cli.c b/library/ssl_tls12_client.c similarity index 100% rename from library/ssl_cli.c rename to library/ssl_tls12_client.c diff --git a/library/ssl_srv.c b/library/ssl_tls12_server.c similarity index 100% rename from library/ssl_srv.c rename to library/ssl_tls12_server.c diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh index 69b1fc83e2..e732ae47db 100755 --- a/tests/scripts/all.sh +++ b/tests/scripts/all.sh @@ -2169,14 +2169,14 @@ component_build_no_std_function () { } component_build_no_ssl_srv () { - msg "build: full config except ssl_srv.c, make, gcc" # ~ 30s + msg "build: full config except SSL server, make, gcc" # ~ 30s scripts/config.py full scripts/config.py unset MBEDTLS_SSL_SRV_C make CC=gcc CFLAGS='-Werror -Wall -Wextra -O1' } component_build_no_ssl_cli () { - msg "build: full config except ssl_cli.c, make, gcc" # ~ 30s + msg "build: full config except SSL client, make, gcc" # ~ 30s scripts/config.py full scripts/config.py unset MBEDTLS_SSL_CLI_C make CC=gcc CFLAGS='-Werror -Wall -Wextra -O1'