add debug, fix warnings

lib/egl/surface.cpp

@@ -163,6 +163,8 @@ Surface::SwapBuffers()
 
           EGLint result = (*f).second();
 
+          (void) result;
+
           D_DEBUG_AT( DFBEGL_Surface, "  -> SwapBuffers from %s returned 0x%04x '%s'\n",
                       (*f).first.c_str(), result, *ToString<EGLInt>( result ) );
      }

lib/egl/util.cpp

@@ -250,7 +250,7 @@ DFBResult
 Util::GetSurfaceDescription( Graphics::Options     &options,
                              DFBSurfaceDescription &desc )
 {
-     long val;
+     long val = 0;
 
      D_DEBUG_AT( DFBEGL_Util, "EGL::Util::%s()\n", __FUNCTION__ );
 

proxy/dispatcher/idirectfbsurface_dispatcher.c

@@ -2032,9 +2032,8 @@ static DirectResult
 Dispatch_GetFrameTime( IDirectFBSurface *thiz, IDirectFBSurface *real,
                        VoodooManager *manager, VoodooRequestMessage *msg )
 {
-     DFBResult           ret;
+     DFBResult ret;
-     long long           micros;
+     long long micros;
-     VoodooMessageParser parser;
 
      DIRECT_INTERFACE_GET_DATA(IDirectFBSurface_Dispatcher)
 

src/core/CoreDFB_real.cpp

@@ -242,8 +242,10 @@ ICore_Real::GetSurface( u32           surface_id,
      }
 
      ret = dfb_core_get_surface( core, surface_id, &surface );
-     if (ret)
+     if (ret) {
+          D_DEBUG_AT( DirectFB_CoreDFB, "  -> dfb_core_get_surface: %s!\n", DirectFBErrorString(ret) );
           return ret;
+     }
 
      if (fusion_config->secure_fusion && dfb_config->ownership_check) {
           ret = (DFBResult) fusion_object_has_access( &surface->object, path );
@@ -256,6 +258,8 @@ ICore_Real::GetSurface( u32           surface_id,
           fusion_object_add_owner( &surface->object, Core_GetIdentity() );
      }
 
+     D_DEBUG_AT( DirectFB_CoreDFB, "  => surface %p\n", surface );
+
      *ret_surface = surface;
 
      return DFB_OK;

src/core/Task.cpp

@@ -158,7 +158,7 @@ Task_DoneFail( Task      *task,
 {
      D_DEBUG_AT( DirectFB_Task, "%s( %p )\n", __FUNCTION__, task );
 
-     D_ASSUME( result != DFB_OK );
+//     D_ASSUME( result != DFB_OK );
 
      task->Done( result );
 }
@@ -330,6 +330,8 @@ Task::AddRef()
 
      (void) refs_now;
 
+     D_ASSERT( refs_now > 1 );
+
      D_DEBUG_AT( DirectFB_Task, "  -> %u refs now\n", refs_now );
 }
 

src/core/layer_region.c

@@ -57,6 +57,7 @@
 #include <core/CoreLayerRegion.h>
 #include <core/CoreSurface.h>
 #include <core/CoreSurfaceClient.h>
+#include <core/Debug.h>
 #include <core/Task.h>
 
 #include <gfx/util.h>
@@ -542,6 +543,8 @@ dfb_layer_region_flip_update( CoreLayerRegion     *region,
           return DFB_UNSUPPORTED;
      }
 
+     D_DEBUG_AT( Core_Layers, "  -> region: %s\n", ToString_CoreLayerRegion(region) );
+
      surface = region->surface;
      layer   = dfb_layer_at( region->layer_id );
 
@@ -661,6 +664,7 @@ dfb_layer_region_flip_update( CoreLayerRegion     *region,
 
           case DLBM_FRONTONLY:
 update_only:
+     D_DEBUG_AT( Core_Layers, "  -> update\n" );
                /* Tell the driver about the update if the region is realized. */
                if (funcs->UpdateRegion && D_FLAGS_IS_SET( region->state, CLRSF_REALIZED )) {
                     CoreSurfaceBufferLock left;