* unit-test CMake: Add option to build with sanitizers
These build options affect both the tests and the code under test when
built from the unit-test CMake file.
Example:
cmake -DSANITIZE=address,undefined
To reset all options:
cmake --fresh
Meson users will find this familiar:
meson -Db_sanitize=…
(When in doubt in CMake, implement what Meson provides out of the box.)
Motivation:
ASan and UBSan currently finds a lot of crashy problems with the unit-tests,
and makes them visible in plain sight.
* unit-test CMake: Remove compile_options(-O0 -Wno-div-by-zero)
Let's not override optimization options: This is surprising when
the cmake user tries to set CMAKE_BUILD_TYPE=(Debug|Release)'.
The -Wno-div-by-zero warning disabling seems obsolete:
Replacing it with -Werror did not fail, at least with Gcc 13.
* unit-test: Fix missing symbol in a few tests (linker error)
I don't know why I get to resolve these, but in all cases,
it is FreeRTOS_Sockets.c that is dragging in a dependency on
xTCPWindowLoggingLevel, causing a few tests to fail to link:
FreeRTOS_Sockets.c:5118:(.text+0x18fa2):
undefined reference to `xTCPWindowLoggingLevel'
Since it's one external variable, let's add it to the necessary unittests.
Also under the headline of extern variables:
The IPv6 address, which was not there for linkage, could be made const.
* unit-test: Fix segfault due to discrepancy between the real and mocked recvfrom
Symptom:
test_vDHCPProcess_eWaitingOffer_CorrectState_ValidBytesInMessage_MatchingEndPoint()
segfaults.
What AddressSanitizer says about that:
test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:1139:28: runtime error:
member access within null pointer of type 'const struct DHCPMessage_IPv4_t'
AddressSanitizer:DEADLYSIGNAL
=================================================================
==14403==ERROR: AddressSanitizer: SEGV on unknown address 0x0000000000ec
==14403==The signal is caused by a READ memory access.
==14403==Hint: address points to the zero page.
#0 0x456eb7 in prvIsValidDHCPResponse test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:1139
#1 0x4584c3 in prvProcessDHCPReplies test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:1280
#2 0x45038c in xHandleWaitingOffer test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:334
#3 0x45366a in vDHCPProcessEndPoint test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:735
#4 0x44fe57 in vDHCPProcess test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:263
#5 0x418d2c in test_vDHCPProcess_eWaitingOffer_CorrectState_ValidBytesInMessage_MatchingEndPoint test/unit-test/FreeRTOS_DHCP/FreeRTOS_DHCP_utest.c:147
Diagnosis:
pxDHCPMessage in prvProcessDHCPReplies() is the unlucky null pointer.
As commented, it is expected to be set as an out-arg of FreeRTOS_recvfrom()
due to calling it with FREERTOS_ZERO_COPY, but the condition for it
in the mocked FreeRTOS_recvfrom() is that the sum of all flags
is FREERTOS_ZERO_COPY + FREERTOS_MSG_PEEK.
Finding the right fix:
Should we add a null check? Nope.
Set the FREERTOS_MSG_PEEK flag? Nope.
The mocked function did not check the FREERTOS_ZERO_COPY flag properly.
Observe that in the real FreeRTOS_recvfrom(),
specifically inside prvRecvFrom_CopyPacket(),
the condition for setting the zero-copy pointer into the buffer with the data
depends only on one flag - FREERTOS_ZERO_COPY - and ignores the rest.
It is obviously important that the mocked condition is exactly the same.
* FreeRTOS_ND_utest: Fix segfaults caused by no ethernet buffer
* test_prvProcessEthernetPacket_*(): Fix memset(NULL, …) segfaults
The pointer was used before initialized.
If it happened to be NULL, the test would segfault.
* unit-test: Fix pxEthernetBuffer[-ipIP_TYPE_OFFSET] buffer underflows
The tested functions intentionally expect there to be bytes before
the ethernet buffer:
* test_FreeRTOS_GetUDPPayloadBuffer_*():
The code under test, FreeRTOS_GetUDPPayloadBuffer_Multi,
writes 6 bytes before the ethernet buffer. This looks
intentional, as the write is commented as doing that.
* FreeRTOS_IP_utest:
The code under test, prvProcessIPPacket() intentionally
writes a byte at offset -ipIP_TYPE_OFFSET into its
ethernet buffer.
I am thankful for the generous comment about the ipIP_TYPE_OFFSET.
* test_vTCPWindowDestroy_list_length_not_zero(): Fix buffer overflow due to struct interposing
The test was crashing due to what AddressSanitizer calls a buffer overflow,
or really, interposing a TCPSegment_t on top of a TCPWindow_t::xRxSegments
member and accessing an interposed struct member that fell outside the
underlying TCPWindow_t struct.
The naive fix - not doing that - works:
void test_vTCPWindowDestroy_list_length_not_zero( void )
{
TCPWindow_t xWindow = { 0 };
- List_t * pxSegments = &( xWindow.xRxSegments );
+ TCPSegment_t xSegment = { 0 };
listLIST_IS_INITIALISED_ExpectAnyArgsAndReturn( pdFALSE );
listLIST_IS_INITIALISED_ExpectAnyArgsAndReturn( pdTRUE );
listCURRENT_LIST_LENGTH_ExpectAnyArgsAndReturn( 1 );
- listGET_OWNER_OF_HEAD_ENTRY_ExpectAnyArgsAndReturn( pxSegments );
+ listGET_OWNER_OF_HEAD_ENTRY_ExpectAnyArgsAndReturn( &xSegment );
/* ->vTCPWindowFree */
- uxListRemove_ExpectAnyArgsAndReturn( pdTRUE );
- uxListRemove_ExpectAnyArgsAndReturn( pdTRUE );
listCURRENT_LIST_LENGTH_ExpectAnyArgsAndReturn( 0 );
vTCPWindowDestroy( &xWindow );
}
However, this became a different test, as evidenced by the less than 100%
line coverage, that two function call expectations had to go, and that it
functionally became an exact copy of the next test.
To reach the holes in the test coverage opened by the naive fix,
the two list items' container pointers also needed and sufficed to be set.
* test_eARPGetCacheEntryByMac_OneMatchingEntry(): Arrest dangling pointer
This test was using the stack of a previously returned function
(probably a previous test). Highlights from AddressSanitizer output:
==15832==ERROR: AddressSanitizer: stack-use-after-return
READ of size 8 at 0x7fdefb013670 thread T0
#0 0x4325bf in eARPGetCacheEntryByMac source/FreeRTOS_ARP.c:930
#1 0x421a71 in test_eARPGetCacheEntryByMac_OneMatchingEntry
(test/unit-test/build/bin/tests/FreeRTOS_ARP_utest+0x421a71)
Address 0x7fdefb013670 is located in stack of thread T0 at offset 624 in frame
#0 0x41f941 in test_vARPRefreshCacheEntry_IPAndMACInDifferentLocations1
(test/unit-test/build/bin/tests/FreeRTOS_ARP_utest+0x41f941)
This frame has 2 object(s):
[48, 54) 'xMACAddress' (line 1937)
[80, 640) 'xEndPoint' (line 1941) <== Memory access at offset 624 is inside this variable
Nulling the dangling pointer is enough to fix the test,
but in order to keep the 100% line coverage,
it must point at somewhere valid.
Therefore doing that.
* FreeRTOS_TCP_Transmission_utest: Fix stack use after return: Point at own endpoint
* FreeRTOS_TCP_IP_utest.c: Fix buffer overflow
* prvTCPNextTimeout(): Fix leftshift by ~0 encountered in unittest
This expression is obviously undefined when ucRepCount is 0 (leftshift by ~0):
3000U << ( ucRepCount - 1U )
Which is fine if that is impossible. But is it? This case is handled later by
clamping the result from 0 to 1 (which hints at how this accidentally works),
and this is being tested for (in FreeRTOS_TCP_IP_utest.c::
test_prvTCPNextTimeout_ConnSyn_State_Active_Rep0).
I'm also surprised that neither Gcc or Clang optimizes the UB away
(which would make the code behave differently with optimization):
1500U << ucRepCount
It is very tempting to apply this fix, but 1ms is very different from 1500ms.
That may well speak more for lowering the scale factor than making exceptions,
though. But not now: For the purpose of fixing sanitizer failures,
let's preserve the behaviour for now.
* FreeRTOS_DNS_Callback_utest: Fix buffer overflow caused by mocked malloc
* test_vReceiveRA_vRAProcess(): Fix buffer overflow in test: Don't cast
The struct used as ethernet buffer did not contain the supposed data.
The supposed data, however, seems to be correct based on this resource:
https://support.huawei.com/enterprise/en/doc/
EDOC1100174721/8ebcb3c3/icmpv6-router-advertisement-ra-message
AddressSanitizer called it a buffer overflow just because the buffer
happened to be shorter than the supposed data.
To make this evident and let type safety prevent this from compiling
the wrong way, let's define a struct that contains the right data,
and take pointers from the addresses of members instead of casting
and doing manual offset calculations as far as possible.
Also remove unused variables.
I also wonder if the first test is not a subset of the second.
It causes a subset of things to happen in the code under test,
and their names only differ by a typo.
* test_DNS_ParseDNSReply_answer_lmmnr_reply3(): Fix test failure due to use before initialization
* DNS: test_SendRequest_fail(): Fix testing the failure scenario
* FreeRTOS_DNS_utest.c: Fix size to copy when copying pointers instead of target
* unit-test of DHCP option parser: Delete the buffer overflow
Symptom:
AddressSanitizer: dynamic-stack-buffer-overflow on address 0x7ffc9dfa5c07
READ of size 1 at 0x7ffc9dfa5c07 thread T0
#0 0x459a49 in prvProcessDHCPReplies test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:1310
#1 0x4526d2 in vHandleWaitingAcknowledge test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:495
#2 0x4544ef in vDHCPProcessEndPoint test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:739
#3 0x43dbd9 in test_vDHCPProcess_eWaitingAcknowledge_DNSIncorrectLength2
(test/unit-test/build/bin/tests/FreeRTOS_DHCP_utest+0x43dbd9)
Address 0x7ffc9dfa5c07 is located in stack of thread T0
SUMMARY: AddressSanitizer: dynamic-stack-buffer-overflow
test/unit-test/build/Annexed_TCP_Sources/FreeRTOS_DHCP.c:1310 in prvProcessDHCPReplies
Shadow bytes around the buggy address:
0x7ffc9dfa5980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x7ffc9dfa5a00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x7ffc9dfa5a80: 00 00 00 00 00 00 00 00 ca ca ca ca 00 00 00 00
0x7ffc9dfa5b00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x7ffc9dfa5b80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x7ffc9dfa5c00:[05]cb cb cb cb cb cb cb 00 00 00 00 00 00 00 00
0x7ffc9dfa5c80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x7ffc9dfa5d00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x7ffc9dfa5d80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x7ffc9dfa5e00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x7ffc9dfa5e80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Left alloca redzone: ca
Right alloca redzone: cb
There were two problems that conspired to create this segfault. The first
was allowing the option parser to run off the end of the buffer at all:
/* ulGenericLength is incremented by 100 to have uxDNSCount > ipconfigENDPOINT_DNS_ADDRESS_COUNT scenario */
ulGenericLength = sizeof( DHCPMsg ) + 100;
The second problem was letting it overshoot the stop byte (0xFF).
Which is a problem with having manually updated indexes and length fields.
The stop byte was at the end of the buffer, but was of no help, because
the buffer length was off by -3 (missing 2 bytes for the opcode and
length field of the 6 server addresses and 1 byte to account for an
unexplained hole in the serialized stream).
The real fix for this kind of fragility is using some helper funcitons
for serializing the data while keeping indexes and lenghts consistent
(not to mention collapsing repeated lines 8-fold).
Anyway, it is trivial to add a check that the serialized stream ends
at the end of the buffer (done).
Whether to add a functioning stop byte does not matter
and should not be needed anymore with such a check.
I initially fixed it the wrong way, by keeping it within the same buffer,
which hurt line coverage. But what the test wants to test is as commented:
At least 6 server addresses, because that's the value of
ipconfigENDPOINT_DNS_ADDRESS_COUNT + 1. No "invalid" length required,
just an overabundance of DNS servers. As such, let's rename the test.
Btw, the test was using a VLA (fixed), and most of the uint32_t writes
are still unaligned (I replaced one of them with memcpy).
* test_eHandleIPv6ExtensionHeaders_TCPHappyPath: Fix buffer overflow
* FreeRTOS_DNS.c: Fix NULL deref encountered in test_FreeRTOS_gethostbyname_SuccessAddressInCache
* FreeRTOS_DNS_Parser_utest: Don't return dangling pointers
UBSan happens to catch this as a misaligned pointer deref within the null page
one moment before segfault:
source/FreeRTOS_DNS_Parser.c:761:49: runtime error:
member access within misaligned address 0x00000000012c for type
'struct freertos_addrinfo', which requires 8 byte alignment
This was traced back to the test test_parseDNSAnswer_dns_nocallback_false(),
which creates an uninitialized pointer and passes it on.
Other tests were also found doing the same, though did not lead to segfault
on GCC 12 and 13, except did on GCC 11 in CI with AddressSanitizer.
This is a class of error that a higher warning level could easily forbid
(reading an uninitialized variable, pointer or not):
-Werror=maybe-uninitialized
* FreeRTOS_DHCP_utest: Fix a read out of bounds
xProcessCheckOption() reads the length from the second byte.
So for the purpose of testing reading the second byte,
but no more, the buffer length was correctly given as 2,
except that the buffer length must then be at least 2.
* FreeRTOS_{DNS,Routing}_utest.c: Fix off-by-one buffer overflows
FreeRTOS_DNS_utest.c::test_FreeRTOS_gethostbyname_FailLongAddress:
Array length vs index of last element:
I was about to add one more byte to the buffer,
but it looked like that had been attempted before
without remembering to initialize them.
Therefore, remove those bytes instead.
FreeRTOS_Routing_utest.c::test_pcEndpointName_IPv{4,6}_HappyPath:
Can be summed up as sizeof() != strlen(). These tests
were copying one byte too many from their test input strings.
Non-functional cleanups:
* Let input strings have static storage duration (avoid copy to stack).
* I found it confusing to take the address of the string constants,
as it performs the same pointer decay as doing nothing.
* unit-test FreeRTOS_DHCP_stubs.c: Fix NetworkBufferDescriptor_t alignment
* FreeRTOS_{DHCPv6,DNS}_utest: Fix memory leaks
Consider undoing this and see if the code under test needs fixing.
LeakSanitizer finds these.
* FreeRTOS_DNS_Parser_utest: Fix misaligned writes in the test
* FreeRTOS_TCP_WIN_utest.c: Fix memory leaks of type free(NULL)
The pointer to the allocated memory was reset. ⏚
* FreeRTOS_DHCP_utest: Fix misaligned writing of DHCP option fields
Symptom (UB Sanitizer):
Store to misaligned address 0x7ffe* for type 'uint32_t',
which requires 4 byte alignment
When repeated, these 4-byte fields are 2 bytes apart
(because of the option and length bytes).
The padding byte added to each test does not solve
this problem (consider removing).
Should have used memcpy (done).
Actually, one thing that makes memcpy tedious is that
it takes an address, not a value.
I got tired of memcpy halfway through;
this is what I mean by helper functions
(see the commit about deleting a buffer overflow):
The ultimate solution is not memcpy, but helpers that
remove those manual indexes and length fields,
and with that, the possibility for inconsistencies
that can lead to such a buffer overflow.
* FreeRTOS_ND_utest.c: Remove failing but redundant test
test_prvProcessICMPMessage_IPv6_NeighborSolicitationCorrectLen()
required these fixes when compiled with -fsanitize=address,memory
+usGenerateProtocolChecksum_IgnoreAndReturn( ipCORRECT_CRC );
+vReturnEthernetFrame_ExpectAnyArgs();
… but only this fix when compiled regularly:
+usGenerateProtocolChecksum_IgnoreAndReturn( ipCORRECT_CRC );
Thankfully, the intention is clear from the comment.
It fails extra with sanitization because the two compared IP addresses
actually do compare equal.
Which is fixable. But removing the test did not impact coverage.
* unit-test: Fix differences between with and without sanitization due to lack of initialization
* unit-test: Add FIXME for behavioural difference with sanitizers
* FreeRTOS_DNS_Parser_utest.c: Fix buffer alignment
* CI: Add SANITIZE=address,undefined build
As commented, it had to be a separate build because branch coverage
(currently) doesn't ignore artificial branches added by sanitizers.
On reusing the same build directory:
It's totally possible to use separate build directories in build/,
but there is no correctness benefit (CMake rebuilds the object files
whose recipe has changed anyway). Rather, CMake saves (130) jobs
that don't need to run again when reusing the same build directory.
On which builds to build and run first (aubsan before coverage):
When it matters, which is when a test is crashing, that's generally
when you want to see the AddressSanitizer output.
* FreeRTOS_ND_utest: Don't use an uninitialized ip address
… it's not fun when it only fails in CI.
The lookup happened to fail to fail with AddressSanitizer,
but only on GCC 11 (not 12 of 13).
* FreeRTOS_DHCP_utest: Fix attempt at making recvfrom return a NULL buffer
With Gcc 11 + AddressSanitizer, the mocked recvfrom would not return
a NULL buffer (unlike Gcc 12 and 13 with and without sanitization).
A custom stub function gave enough control to do that.
The existing FreeRTOS_recvfrom_Generic_NullBuffer() stub did almost the same,
but was unused and meaningless (failed to set its out-argument),
so it could be replaced.
* FreeRTOS_ND_utest: Fix test failures due to missing initialization
test_SendPingRequestIPv6_SendToIP_Pass():
This test segfaulted without AddressSanitizer:
'build/normal/bin/tests/FreeRTOS…' terminated by signal SIGSEGV
test_SendPingRequestIPv6_Assert():
==7143==AddressSanitizer CHECK failed: ../../../../src/libsanitizer/asan/asan_descriptions.cpp:80 "((0 && "Address is not in memory and not in shadow?")) != (0)" (0x0, 0x0)
#0 0x7ff6c812f9a8 in AsanCheckFailed ../../../../src/libsanitizer/asan/asan_rtl.cpp:74
#1 0x7ff6c815032e in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) ../../../../src/libsanitizer/sanitizer_common/sanitizer_termination.cpp:78
#2 0x7ff6c809fa77 in GetShadowKind ../../../../src/libsanitizer/asan/asan_descriptions.cpp:80
#3 0x7ff6c809fa77 in __asan::GetShadowAddressInformation(unsigned long, __asan::ShadowAddressDescription*) ../../../../src/libsanitizer/asan/asan_descriptions.cpp:96
#4 0x7ff6c809fa77 in __asan::GetShadowAddressInformation(unsigned long, __asan::ShadowAddressDescription*) ../../../../src/libsanitizer/asan/asan_descriptions.cpp:93
#5 0x7ff6c80a1296 in __asan::AddressDescription::AddressDescription(unsigned long, unsigned long, bool) ../../../../src/libsanitizer/asan/asan_descriptions.cpp:441
#6 0x7ff6c80a3a84 in __asan::ErrorGeneric::ErrorGeneric(unsigned int, unsigned long, unsigned long, unsigned long, unsigned long, bool, unsigned long) ../../../../src/libsanitizer/asan/asan_errors.cpp:389
#7 0x7ff6c812efc5 in __asan::ReportGenericError(unsigned long, unsigned long, unsigned long, unsigned long, bool, unsigned long, unsigned int, bool) ../../../../src/libsanitizer/asan/asan_report.cpp:476
#8 0x7ff6c80abc44 in __interceptor_memset ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:799
#9 0x55f2e38a3620 in FreeRTOS_SendPingRequestIPv6 build/u22/Annexed_TCP_Sources/FreeRTOS_ND.c:768
#10 0x55f2e3893053 in test_SendPingRequestIPv6_Assert test/unit-test/FreeRTOS_ND/FreeRTOS_ND_utest.c:1065
#11 0x55f2e389c5dd in run_test build/u22/FreeRTOS_ND_utest_runner.c:201
#12 0x55f2e389ca84 in main build/u22/FreeRTOS_ND_utest_runner.c:252
#13 0x7ff6c6bcbd8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f)
#14 0x7ff6c6bcbe3f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e3f)
#15 0x55f2e38873d4 in _start (build/u22/bin/tests/FreeRTOS_ND_utest+0x233d4
test_prvProcessICMPMessage_IPv6_NeighborSolicitationNullEP()
behaved different with and without ASan on Gcc 11.
Without AddressSanitizer on Gcc 11:
FreeRTOS_ND_utest.c:1427:test_prvProcessICMPMessage_IPv6_NeighborSolicitationNullEP:
FAIL:Function usGenerateProtocolChecksum. Called more times than expected.
* test_lTCPWindowTxAdd_nothing_to_do(): Fix TCP window initialization
Under Gcc 11, this expression in the tested function lTCPWindowTxAdd()
was always true, leading to imperfect coverage:
pxSegment->lDataLength < pxSegment->lMaxLength
With Gcc 13, they were both 0.
Let's add zero-initialization to make this what's tested for.
---------
Co-authored-by: Tony Josi <tonyjosi@amazon.com>
* Use new version of CI-CD Actions, checkout@v3 instead of checkout@v2 on all jobs
* Use cSpell spell check, and use ubuntu-20.04 for formatting check
* Add in bot formatting action
* Updating tcp utilities
* Some more change in dev_integration_hein.v8
* In FreeRTOS_DNS_Parser.c : use 'ipUDP_PAYLOAD_OFFSET_IPv4' in stead of 'ipIP_PAYLOAD_OFFSET'
* And a few more corrections
* Changes to WinPCap network interface, removed debugging code
* After applying uncrustify
* Oops, I forgot the push changes in include files.
* Now removing it, hopefully
---------
Co-authored-by: Nikhil Kamath <110539926+amazonKamath@users.noreply.github.com>
Co-authored-by: Monika Singh <108652024+moninom1@users.noreply.github.com>
* Use CBMC XML output to enable VSCode debugger (#673)
Prior to this commit, CBMC would emit logging information in plain text
format, which does not contain information required for the CBMC VSCode
debugger. This commit makes CBMC use XML instead of plain text.
Co-authored-by: Mark Tuttle <tuttle@acm.org>
* fix the CBMC proof build and fail due to non inclusion of actaul src files
* fix the CBMC proof build and fail due to non inclusion of actaul src files
* adding tcp transmission v4 src to build
* fix cbmc proof for CheckOptionsInner
* updating as per review comments
* fix check option CBMC proofs
* removing unused assumptions
---------
Co-authored-by: Kareem Khazem <karkhaz@amazon.com>
Co-authored-by: Mark Tuttle <tuttle@acm.org>
* Reparations and recommendations for the dev/IPv6_integration branch
* Applied uncrustify
* More changes after testing ARP, ICMP4, ICMP6, UDPv4 and UDPv6, DNSv6
* A few changes to DNS after testing it
* Fix FreeRTOS_IP and FreeRTOS_IP_DiffConfig test cases
* Remove test_prvProcessIPEventsAndTimers_eNetworkDownEvent test Case
- eNetworkDownEvent no longer support xNetworkUp variable, the network status
is kept in pxEndPoint->bits.bEndPointUp.
* Run Uncrustify.
Co-authored-by: GitHub Action <action@github.com>
* Add EndPoint changes to FreeRTOS_Socket.c
* Split Socket.c to IPv4 and IPv6 files
* Combine freertos_sockaddr for IPv4 and IPv6
* Update sendto and recv function to handle IPv4 and IPv6 case
* Run uncrustify
* Add common Header size function for IPv6 and IPv4
* MISRA: Fix rule 1.1, 10.3, 20.9 and suppress rule 20.5
Co-authored-by: Monika Singh <moninom@amazon.com>
* Add IPv6 specific header files.
* Update according to Coding Guidelines and Uncrustify
* Adding common IP file to handle common strctures
Co-authored-by: Monika Singh <moninom@amazon.com>
* IPv4/single: Let connect() return as soon as socket gets closed
* Let both connect() and accept() return after a 'eSOCKET_CLOSED' event
* Included hang protection of orphaned socket from PR #545
* Lexicon.txt change
* Remove a variable that was not used
* Update source/FreeRTOS_Sockets.c
Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com>
* Update source/FreeRTOS_TCP_IP.c
Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com>
* moved declaration to beginning of block
* Update source/FreeRTOS_TCP_IP.c
Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com>
* Uncrustify: triggered by comment.
* Fix unit test expectations
* Avoid a recursive call to vTCPStateChange()
* Uncrustify: triggered by comment.
* Fix CBMC proof assumptions
* Get unit-test coverage up
* Fix timers unit-tests
* Socket unit-test for closed socket
* Fix a unit-test expectations
* Fix spell check
* Uncrustify: triggered by comment.
* Using debug_printf in stead of printf for logging.
* Use debug printf instead of printf in 2 locations
Co-authored-by: Hein Tibosch <hein@htibosch.net>
Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
* Update source location for coverity
* Add coverage checker
* Add build check with default configuration
* Fix build combination and DNS error
* uncrustified and fixed cmakelists
* This commit updates version number in all files to Development-Branch
* Update version number macros
* This commit fixes a typo in version number macro
* Added a 'critical section' to prevent a race condition in stream buffers
* Uncrustify: triggered by comment.
* Fixed unit-tests by adding mocked functions
* Initial commit of file README.md
* Update README.md
* Fix the title of README file in coverity
* Addressed issue comments
* Update command
* Add details about remaining exception
* Move file to original location
* Remove use of sudo in commands
* Fix links; added coverity version note
* Update README.md
* Remove CMake installation instructions
* Update manifest/history and copyright year
* Update kernel version to 10.4.5
* Update remaining copyright year instances
* Update the version number macros
* Update license header titles
* Remove kernel license header and add TCP header
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com>
* Update source location for coverity
* Add coverage checker
* Add build check with default configuration
* Fix build combination and DNS error
* uncrustified and fixed cmakelists
* This commit updates version number in all files to Development-Branch
* Update version number macros
* This commit fixes a typo in version number macro
This commit brings in the refactoring and restructuring changes
from IntegrationTesting1 branch to the main branch.
It also includes additional unit tests for 100% coverage.
The rationale behind not creating a PR is that the conflicts were too
huge to be resolved correctly. Thus, a force push to the main branch is
being done.
