Gordon Wang
211fc9dcc8
Implement MQTT Disconnect ( #885 )
2020-04-24 14:32:28 -07:00
Gordon Wang
52b2372cca
Add plaintext transport implementation ( #872 )
2020-04-20 09:48:10 -07:00
Gordon Wang
210e7fe39c
Add MQTT connect API implementation ( #870 )
2020-04-15 15:50:47 -07:00
Gordon Wang
28a501569d
Add MQTT lightweight files with CONNECT implementation ( #866 )
2020-04-14 14:46:30 -07:00
Gordon Wang
382f860ba5
Add config file
2020-04-10 11:35:01 -07:00
Gordon Wang
3f74c048c9
Create development branch
2020-04-10 11:25:11 -07:00
leegeth
d1c29b1c41
Move the source and include variables in CMakeLists.txt to a common file ( #859 )
2020-04-09 11:02:37 -07:00
Felipe R. Monteiro
9f7f92ce8d
Avoid null dereferences in IotMqtt_Connect ( #858 )
...
* Check for consistency in userName and password on IotMqttConnectInfo_t
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
* Check for nullness in IotMqtt_Connect's parameters
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
2020-04-08 19:35:00 -04:00
Felipe R. Monteiro
0664feba86
Avoid null dereference in IotMqtt_PublishSync ( #828 )
...
* Avoid null dereference in IotMqtt_PublishSync
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
* All variables must be declared at the start of the function
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
2020-03-20 17:09:57 -04:00
abhidixi11
30cb8851cc
fix: 'Potentially uninitialized variable' warning. ( #813 )
...
Fixed warning by moving initialization.
2020-03-18 16:42:47 -07:00
Felipe R. Monteiro
810016d447
Avoid undefined behaviour in IotMqtt_IsSubscribed function ( #825 )
...
* Remove unnecessary assumption from IotMqtt_IsSubscribed proof
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
* Avoid undefined behaviour with NULL pTopicFilter
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
* All variables must be declared at the start of the function
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
2020-03-18 16:12:36 -04:00
Muneeb Ahmed
3af0f939c5
Make certain helper functions static ( #795 )
2020-02-12 09:53:36 -08:00
Gordon Wang
66e0564957
Complete coverage of iot_mqtt_lightweight_api.c ( #792 )
2020-02-11 16:06:03 -08:00
Gordon Wang
da76fbff4b
Complete coverage of iot_mqtt_serialize.c ( #787 )
2020-02-11 11:26:50 -08:00
Muneeb Ahmed
0a0e26e296
Address MISRA for LW API, sync changes ( #777 )
...
* Address MISRA violations
* Log warning if metrics username is too large
2020-02-11 11:11:00 -08:00
Gordon Wang
d87bad955e
Complete coverage of iot_mqtt_helper.c ( #786 )
2020-02-10 15:29:53 -08:00
Gordon Wang
ecf07347b5
Only send PINGREQ when connection is idle ( #778 )
2020-02-10 10:20:08 -08:00
Muneeb Ahmed
08d31b823d
Fix platform test failure ( #783 )
2020-02-10 10:11:06 -08:00
abhidixi11
df6bd64cd7
chore: Changed managed API to use common code. ( #784 )
...
* chore: Changed managed API to use common code.
Use helper functions in iot_mqtt_serialize.c.
2020-02-09 16:57:40 -08:00
Muneeb Ahmed
e64e3fdee7
Move dependent MQTT tests to platform group ( #782 )
...
* Add reentrant tests to platform group
* Remove reentrancy tests from system
* Move SingleThreaded test to platform group
* Move SubscriptionReferences test to platform group
2020-02-07 16:16:56 -08:00
Gordon Wang
9f1a3978f3
Documentation update for MQTT design ( #775 )
...
* Documentation update for MQTT design
2020-02-04 16:34:06 -08:00
abhidixi11
cf2c232145
Feat: Refactor MQTT Light Weight API code ( #772 )
...
* Feat: Refactor MQTT Light Weight API code
Light Weight API code has been factored out and put in separate files.
2020-02-04 15:21:47 -08:00
Muneeb Ahmed
e811e28f8d
Address MISRA 21.15, reduce complexity ( #761 )
...
* Reduce complexity for _encodeUserName
* Address MISRA 21.15
* Add warnings to _encodeUserName* functions
2020-02-04 13:31:05 -08:00
Gordon Wang
34a74ccfdc
Increase test coverage of iot_mqtt_operation.c ( #771 )
2020-02-03 16:50:24 -08:00
Gordon Wang
9667d656ac
Increase coverage of iot_mqtt_network.c ( #770 )
2020-02-03 12:28:29 -08:00
abhidixi11
ff0d4c00c9
Fix: Unused variable warning. ( #765 )
...
Unused variable warning when AWS_IOT_MQTT_ENABLE_METRICS is set to 0.
2020-02-03 10:19:00 -08:00
Muneeb Ahmed
dc818b6e8e
Fix MISRA 10.3 violation ( #767 )
2020-01-31 20:41:42 -08:00
Gordon Wang
17e9a7c713
Increase coverage in iot_mqtt_api.c ( #769 )
2020-01-31 20:31:08 -08:00
qiutongs
79f64d61a7
Fix MISRA 20.9 by providing default macro definitions ( #763 )
2020-01-31 15:01:15 -08:00
Gordon Wang
a0e0001417
Re-enable checks for resource allocation failure ( #768 )
2020-01-31 11:58:15 -08:00
Muneeb Ahmed
748b380788
Address MQTT MISRA 11.5, 11.8, and 11.9 ( #753 )
...
* Fix and annotate MISRA 11.8
* Turn 11.8 violations into 8.13 violations
* Fix MQTT MISRA 11.9 violation
* Disable 11.5 in MISRA config
2020-01-30 14:25:11 -08:00
Gordon Wang
16589269f9
Complete coverage of iot_mqtt_subscription.c ( #762 )
2020-01-30 13:30:18 -08:00
Gordon Wang
e6c4b71266
Complete coverage of iot_mqtt_validate.c ( #757 )
2020-01-30 09:44:21 -08:00
abhidixi11
7c0abbd1ce
Fix build failure when AWS_IOT_MQTT_ENABLE_METRICS is disabled. ( #759 )
...
* Fix: CSDK build failure.
Fix build failure when AWS_IOT_MQTT_ENABLE_METRICS is disabled.
2020-01-29 16:34:20 -08:00
qiutongs
46c7a8942e
Suppress MISRA 19.2 in MQTT files ( #756 )
2020-01-29 16:17:38 -08:00
abhidixi11
445fec4c65
Fix: Reduce code complexity below 9 Part 2 ( #742 )
...
* Fix: Reduce code complexity below 9 Part 2
Files in PR: iot_mqtt_api.c
2020-01-29 15:34:50 -08:00
qiutongs
645f39cec5
Annotate mqtt source files to suppress MISRA 20.7 ( #752 )
2020-01-29 11:37:22 -08:00
Muneeb Ahmed
4e1fc45c76
Address MQTT MISRA 15 ( #748 )
...
* Fix MISRA 14.3 annotation
* Address MISRA 15.4
* Address MISRA 15.5
2020-01-29 10:59:03 -08:00
Muneeb Ahmed
79079aa728
MQTT MISRA 7.4, 8.2, 8.3, 8.4 ( #747 )
...
* Address MISRA 7.4 false positive
* Address MISRA 8.4
* Address MISRA 8.2
* Address MISRA 8.3
* Address MISRA 8.13 - part 1
2020-01-28 00:53:39 -08:00
qiutongs
c64a4dbab1
Fix MISRA 20.7 in iot_mqtt_serialize.c ( #749 )
2020-01-27 20:11:48 -08:00
SarenaAWS
08470cd637
Fix MISRA Rule 10.8 on MQTT files. ( #744 )
...
Fix missed 10.4 and 10.3 rules.
2020-01-25 17:24:11 -08:00
Muneeb Ahmed
2eee9fb45f
Address MISRA 17.7, 17.8, and 18.7 in MQTT ( #741 )
...
* Address MISRA 17.7 violations
* Address MISRA 17.8 violations
* Ignore MISRA 18.7 for MQTT subscriptions struct
* Rename synchronous flags
2020-01-24 16:08:43 -08:00
abhidixi11
7df528d57c
Reduce code complexity. ( #740 )
...
* fix: MISRA 15.1 (goto) violations - part 2
This PR has changes for iot_mqtt_api.c.
* fix: MISRA 15.1 (goto) violations - part 2
This commit has changes for iot_mqtt_operation.c.
* fix: MISRA 15.1 (goto) violations - part 2
This commit has changes for iot_mqtt_subscription.c.
* fix: MISRA 15.1 (goto) violations - part 2
Addressed review comments.
* fix: Add 'misra' word in lexicon file.
Added a new word to avoid spellcheck failure.
* fix: MISRA 15.1 (goto) violations - part 2
Addressed review comments.
* Fix: Reduce code complexity below 9
Files in PR: iot_mqtt_network.c iot_mqtt_operation.c
* Fix: Reduce code complexity below 9
Files in PR: iot_mqtt_network.c iot_mqtt_operation.c
2020-01-23 16:03:46 -08:00
Muneeb Ahmed
5a72e25de9
Address MISRA 12.1, 13, and 14 ( #726 )
2020-01-23 14:57:09 -08:00
Muneeb Ahmed
de2bc203ea
Comply with MISRA Rules 11.1, 15.7, and 16.4 ( #728 )
...
* Address MISRA 15.7 and 16.4
* Comply with MISRA 11.1
Co-authored-by: Gary Wicker <14828980+gkwicker@users.noreply.github.com>
2020-01-23 14:24:11 -08:00
Muneeb Ahmed
2df3f9a34d
Address MISRA Rule 11.2 violations ( #730 )
2020-01-23 10:56:46 -08:00
abhidixi11
21a8881ff7
Fix MISRA 15.1 part 3 ( #729 )
...
* fix: MISRA 15.1 (goto) violations - part 3.
Changes made to iot_mqtt_serialize.c and iot_mqtt_validate.c.
2020-01-22 11:34:25 -08:00
Sarena Meas
2573a291a0
MISRA Rules 10.4 and 10.7 on MQTT library files and iot_atomic_gcc.h ( #725 )
...
* MISRA Rule 10.4 updates on all MQTT library files and iot_atomic_gcc.h
* Update IotLog() in coverity annotation comment for specificity.
* Add IotLogError to the lexicon.
2020-01-20 18:36:40 -08:00
Sarena Meas
56259ac065
MISRA Rule 10.3 updates for MQTT files and iot_atomic_gcc.h ( #724 )
...
* Update MQTT files and iot_atomic_gcc.h for MISRA Rule 10.3 violations.
2020-01-20 18:22:11 -08:00
Sarena Meas
a5323a78c0
Check for a NULL pOperation before cleaning up. ( #722 )
...
Before _deserializePublish would immediately goto cleanup if the MallocOperation failed.
In commit f1a8b698b the goto was deleted.
2020-01-17 14:13:41 -08:00