Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-14 19:08:07 +08:00
Code Issues Projects Releases Wiki Activity

cmPolicies: Trivialize GetPolicyStatus method.

Browse Source 
It would be possible to implement this with an XMacro and switch
statement, but every codepath currently would still return WARN.
This commit is contained in:
Stephen Kelly
2015-05-03 10:10:38 +02:00
parent dbf680d670
commit 387aff200c
1 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
Source/cmPolicies.cxx
View File

@@ -124,15 +124,12 @@ const char* idToShortDescription(cmPolicies::PolicyID id)
class cmPolicy
{
public:
cmPolicy(cmPolicies::PolicyID iD,
cmPolicies::PolicyStatus status)
cmPolicy(cmPolicies::PolicyID iD)
{
this->ID = iD;
this->Status = status;
}
cmPolicies::PolicyID ID;
cmPolicies::PolicyStatus Status;
};
cmPolicies::cmPolicies()
@@ -460,10 +457,9 @@ void cmPolicies::DefinePolicy(cmPolicies::PolicyID iD,
unsigned int,
unsigned int,
unsigned int,
cmPolicies::PolicyStatus status)
cmPolicies::PolicyStatus)
{
this->Policies[iD] = new cmPolicy(iD,
status);
this->Policies[iD] = new cmPolicy(iD);
}
//----------------------------------------------------------------------------
@@ -664,18 +660,9 @@ std::string cmPolicies::GetRequiredPolicyError(cmPolicies::PolicyID id)
///! Get the default status for a policy
cmPolicies::PolicyStatus
cmPolicies::GetPolicyStatus(cmPolicies::PolicyID id)
cmPolicies::GetPolicyStatus(cmPolicies::PolicyID)
{
// if the policy is not know then what?
std::map<cmPolicies::PolicyID,cmPolicy *>::iterator pos =
this->Policies.find(id);
if (pos == this->Policies.end())
{
// TODO is this right?
return cmPolicies::WARN;
}
return pos->second->Status;
return cmPolicies::WARN;
}
//----------------------------------------------------------------------------