Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-19 11:18:40 +08:00
Code Issues Projects Releases Wiki Activity

VS: Drop StdOutEncoding with VS 16.6 pending investigation

Browse Source 
The `StdOutEncoding` added to `.vcxproj` files since commit bc877a7e94
(Add support to indicate UTF-8 custom command pipe output encoding,
2020-04-08) breaks custom commands with symbolic outputs on VS 16.6.0.
Disable it pending further investigation and possibly a fix in VS.

Issue: #20769
This commit is contained in:
Brad King
2020-05-29 08:14:39 -04:00
parent 25b63e06a1
commit 5058fb5401
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Source/cmVisualStudio10TargetGenerator.cxx
View File

@@ -4951,7 +4951,10 @@ std::string cmVisualStudio10TargetGenerator::GetCMakeFilePath(
return path;
}
void cmVisualStudio10TargetGenerator::WriteStdOutEncodingUtf8(Elem& e1)
void cmVisualStudio10TargetGenerator::WriteStdOutEncodingUtf8(Elem& /* e1 */)
{
e1.Element("StdOutEncoding", "UTF-8");
// FIXME: As of VS 16.6.0, this breaks custom commands with symbolic outputs.
// See https://gitlab.kitware.com/cmake/cmake/-/issues/20769 for details.
// Disable it for now.
// e1.Element("StdOutEncoding", "UTF-8");
}