Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-16 05:26:58 +08:00
Code Issues Projects Releases Wiki Activity

cmTarget: Extract location computation methods

Browse Source
This commit is contained in:
Stephen Kelly
2016-10-13 00:18:23 +02:00
parent a55cac4ba4
commit 7d57c1a2c9
1 changed files with 44 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

98
Source/cmTarget.cxx
View File

@@ -1039,6 +1039,10 @@ public:
private: private:
static bool HandleLocationPropertyPolicy(std::string const& tgtName, static bool HandleLocationPropertyPolicy(std::string const& tgtName,
cmMakefile* context); cmMakefile* context);
static const char* ComputeLocationForBuild(cmTarget const* tgt);
static const char* ComputeLocation(cmTarget const* tgt,
std::string const& config);
}; };
bool cmTargetPropertyComputer::HandleLocationPropertyPolicy( bool cmTargetPropertyComputer::HandleLocationPropertyPolicy(
@@ -1072,6 +1076,42 @@ bool cmTargetPropertyComputer::HandleLocationPropertyPolicy(
return messageType != cmake::FATAL_ERROR; return messageType != cmake::FATAL_ERROR;
} }
const char* cmTargetPropertyComputer::ComputeLocationForBuild(
cmTarget const* tgt)
{
static std::string loc;
if (tgt->IsImported()) {
loc = tgt->ImportedGetFullPath("", false);
return loc.c_str();
}
cmGlobalGenerator* gg = tgt->GetMakefile()->GetGlobalGenerator();
if (!gg->GetConfigureDoneCMP0026()) {
gg->CreateGenerationObjects();
}
cmGeneratorTarget* gt = gg->FindGeneratorTarget(tgt->GetName());
loc = gt->GetLocationForBuild();
return loc.c_str();
}
const char* cmTargetPropertyComputer::ComputeLocation(
cmTarget const* tgt, std::string const& config)
{
static std::string loc;
if (tgt->IsImported()) {
loc = tgt->ImportedGetFullPath(config, false);
return loc.c_str();
}
cmGlobalGenerator* gg = tgt->GetMakefile()->GetGlobalGenerator();
if (!gg->GetConfigureDoneCMP0026()) {
gg->CreateGenerationObjects();
}
cmGeneratorTarget* gt = gg->FindGeneratorTarget(tgt->GetName());
loc = gt->GetFullPath(config, false);
return loc.c_str();
}
const char* cmTargetPropertyComputer::GetProperty(cmTarget const* tgt, const char* cmTargetPropertyComputer::GetProperty(cmTarget const* tgt,
const std::string& prop, const std::string& prop,
cmMakefile* context) cmMakefile* context)
@@ -1089,31 +1129,7 @@ const char* cmTargetPropertyComputer::GetProperty(cmTarget const* tgt,
!HandleLocationPropertyPolicy(tgt->GetName(), context)) { !HandleLocationPropertyPolicy(tgt->GetName(), context)) {
return CM_NULLPTR; return CM_NULLPTR;
} }
return ComputeLocationForBuild(tgt);
// Set the LOCATION property of the target.
//
// For an imported target this is the location of an arbitrary
// available configuration.
//
if (tgt->IsImported()) {
static std::string loc;
loc = tgt->ImportedGetFullPath("", false);
return loc.c_str();
} else {
// For a non-imported target this is deprecated because it
// cannot take into account the per-configuration name of the
// target because the configuration type may not be known at
// CMake time.
cmGlobalGenerator* gg = tgt->GetMakefile()->GetGlobalGenerator();
if (!gg->GetConfigureDoneCMP0026()) {
gg->CreateGenerationObjects();
}
cmGeneratorTarget* gt = gg->FindGeneratorTarget(tgt->GetName());
static std::string loc;
loc = gt->GetLocationForBuild();
return loc.c_str();
}
} }
// Support "LOCATION_<CONFIG>". // Support "LOCATION_<CONFIG>".
@@ -1123,22 +1139,9 @@ const char* cmTargetPropertyComputer::GetProperty(cmTarget const* tgt,
return CM_NULLPTR; return CM_NULLPTR;
} }
const char* configName = prop.c_str() + 9; const char* configName = prop.c_str() + 9;
return ComputeLocation(tgt, configName);
if (tgt->IsImported()) {
static std::string loc;
loc = tgt->ImportedGetFullPath(configName, false);
return loc.c_str();
} else {
cmGlobalGenerator* gg = tgt->GetMakefile()->GetGlobalGenerator();
if (!gg->GetConfigureDoneCMP0026()) {
gg->CreateGenerationObjects();
}
cmGeneratorTarget* gt = gg->FindGeneratorTarget(tgt->GetName());
static std::string loc;
loc = gt->GetFullPath(configName, false);
return loc.c_str();
}
} }
// Support "<CONFIG>_LOCATION". // Support "<CONFIG>_LOCATION".
else if (cmHasLiteralSuffix(prop, "_LOCATION") && else if (cmHasLiteralSuffix(prop, "_LOCATION") &&
!cmHasLiteralPrefix(prop, "XCODE_ATTRIBUTE_")) { !cmHasLiteralPrefix(prop, "XCODE_ATTRIBUTE_")) {
@@ -1148,20 +1151,7 @@ const char* cmTargetPropertyComputer::GetProperty(cmTarget const* tgt,
!HandleLocationPropertyPolicy(tgt->GetName(), context)) { !HandleLocationPropertyPolicy(tgt->GetName(), context)) {
return CM_NULLPTR; return CM_NULLPTR;
} }
if (tgt->IsImported()) { return ComputeLocation(tgt, configName);
static std::string loc;
loc = tgt->ImportedGetFullPath(configName, false);
return loc.c_str();
} else {
cmGlobalGenerator* gg = tgt->GetMakefile()->GetGlobalGenerator();
if (!gg->GetConfigureDoneCMP0026()) {
gg->CreateGenerationObjects();
}
cmGeneratorTarget* gt = gg->FindGeneratorTarget(tgt->GetName());
static std::string loc;
loc = gt->GetFullPath(configName, false);
return loc.c_str();
}
} }
} }
} }