Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-17 15:32:10 +08:00
Code Issues Projects Releases Wiki Activity

Trust umask for file permissions

Browse Source 
Open output files with mode 0666 so that permissions are not more strict
than umask permits.  See issue #10126.
This commit is contained in:
Brad King
2010-01-12 11:57:01 -05:00
parent 6c1e24276f
commit 8d0161c8ff
3 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/cmFileCommand.cxx
View File

@@ -189,9 +189,7 @@ bool cmFileCommand::HandleWriteCommand(std::vector<std::string> const& args,
#elif defined( __BORLANDC__ )
S_IRUSR | S_IWUSR
#else
S_IRUSR | S_IWUSR |
S_IRGRP |
S_IROTH
0666
#endif
;
@@ -202,7 +200,7 @@ bool cmFileCommand::HandleWriteCommand(std::vector<std::string> const& args,
#if defined( _MSC_VER ) || defined( __MINGW32__ )
S_IREAD | S_IWRITE
#else
S_IRUSR | S_IWUSR
0666
#endif
);
}

6
Source/cmWriteFileCommand.cxx
View File

@@ -60,9 +60,7 @@ bool cmWriteFileCommand
#elif defined( __BORLANDC__ )
S_IRUSR | S_IWUSR
#else
S_IRUSR | S_IWUSR |
S_IRGRP |
S_IROTH
0666
#endif
;
@@ -73,7 +71,7 @@ bool cmWriteFileCommand
#if defined( _MSC_VER ) || defined( __MINGW32__ )
S_IREAD | S_IWRITE
#else
S_IRUSR | S_IWUSR
0666
#endif
);
}

5
Source/kwsys/ProcessUNIX.c
View File

@@ -1875,9 +1875,8 @@ static int kwsysProcessSetupOutputPipeFile(int* p, const char* name)
/* Close the existing descriptor. */
kwsysProcessCleanupDescriptor(p);
/* Open a file for the pipe to write (permissions 644). */
if((fout = open(name, O_WRONLY | O_CREAT | O_TRUNC,
S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH)) < 0)
/* Open a file for the pipe to write. */
if((fout = open(name, O_WRONLY | O_CREAT | O_TRUNC, 0666)) < 0)
{
return 0;
}