Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-15 20:46:37 +08:00
Code Issues Projects Releases Wiki Activity

cmCommandLineArgument: Correctly record parsing failures

Browse Source
This commit is contained in:
Robert Maynard
2021-05-12 09:43:33 -04:00
parent 1ad4501ae9
commit 928cdb17c5
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/cmCommandLineArgument.h
View File

@@ -98,17 +98,11 @@ struct cmCommandLineArgument
// parse the string to get the value // parse the string to get the value
auto possible_value = cm::string_view(input).substr(this->Name.size()); auto possible_value = cm::string_view(input).substr(this->Name.size());
if (possible_value.empty()) { if (possible_value.empty()) {
parseState = ParseMode::SyntaxError;
parseState = ParseMode::ValueError; parseState = ParseMode::ValueError;
} else if (possible_value[0] == '=') { } else if (possible_value[0] == '=') {
possible_value.remove_prefix(1); possible_value.remove_prefix(1);
if (possible_value.empty()) { if (possible_value.empty()) {
parseState = ParseMode::ValueError; parseState = ParseMode::ValueError;
} else {
parseState = this->StoreCall(std::string(possible_value),
std::forward<CallState>(state)...)
? ParseMode::Valid
: ParseMode::Invalid;
} }
} }
if (parseState == ParseMode::Valid) { if (parseState == ParseMode::Valid) {
@@ -150,6 +144,8 @@ struct cmCommandLineArgument
: ParseMode::Invalid; : ParseMode::Invalid;
index = (nextValueIndex - 1); index = (nextValueIndex - 1);
} }
} else {
parseState = ParseMode::SyntaxError;
} }
} }