Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-16 05:26:58 +08:00
Code Issues Projects Releases Wiki Activity

cmUVProcessChain: Tolerate fileno() of invalid FILE stream

Browse Source 
On Windows, in a GUI process without a console, the `std{in,out,err}`
standard FILE streams may not be open.  Avoid passing an invalid file
descriptor to the child process, and let libuv attach NUL instead.

Fixes: #25625
This commit is contained in:
Brad King
2024-01-24 10:27:20 -05:00
parent b6e4e4babc
commit adb3e13d32
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/cmUVProcessChain.cxx
View File

@@ -122,7 +122,11 @@ cmUVProcessChainBuilder& cmUVProcessChainBuilder::SetExternalStream(
cmUVProcessChainBuilder& cmUVProcessChainBuilder::SetExternalStream( cmUVProcessChainBuilder& cmUVProcessChainBuilder::SetExternalStream(
Stream stdio, FILE* stream) Stream stdio, FILE* stream)
{ {
return this->SetExternalStream(stdio, cm_fileno(stream)); int fd = cm_fileno(stream);
if (fd >= 0) {
return this->SetExternalStream(stdio, fd);
}
return this->SetNoStream(stdio);
} }
cmUVProcessChainBuilder& cmUVProcessChainBuilder::SetMergedBuiltinStreams() cmUVProcessChainBuilder& cmUVProcessChainBuilder::SetMergedBuiltinStreams()