Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-20 12:53:55 +08:00
Code Issues Projects Releases Wiki Activity

cmake-gui: Fix regression that prints an incidental error on fresh build trees

Browse Source 
Since commit a872844908 (cmake-gui: Handle relative paths in the build
directory text input, 2024-04-24, v3.30.0-rc1~5^2), `cmake-gui` gave an
incidental error message even when a valid build directory was being
passed.  Fix this by checking for a non-empty path before using it.

Fixes: #26744
This commit is contained in:
Juan Ramos
2025-03-05 15:21:42 -08:00
committed by Brad King
parent 2bd6fbe1b0
commit e9c494005c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Source/QtDialog/QCMake.cxx
View File

@@ -94,7 +94,8 @@ void QCMake::setSourceDirectory(const QString& _dir)
emit this->sourceDirChanged(this->SourceDirectory); emit this->sourceDirChanged(this->SourceDirectory);
this->loadPresets(); this->loadPresets();
this->setPreset(QString{}); this->setPreset(QString{});
if (!cmSystemTools::FileIsFullPath( if (!this->MaybeRelativeBinaryDirectory.isEmpty() &&
!cmSystemTools::FileIsFullPath(
this->MaybeRelativeBinaryDirectory.toStdString())) { this->MaybeRelativeBinaryDirectory.toStdString())) {
this->setBinaryDirectory(this->MaybeRelativeBinaryDirectory); this->setBinaryDirectory(this->MaybeRelativeBinaryDirectory);
} }