Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-15 12:16:40 +08:00
Code Issues Projects Releases Wiki Activity

cmake-gui: Fix use-after-free in Open-possible check

Browse Source 
Fix `QCMake::checkOpenPossible` to copy `toLocal8Bit().data()` before
its lifetime expires.
This commit is contained in:
Francisco Facioni
2020-03-20 07:10:35 -04:00
committed by Brad King
parent e3185e3d1b
commit ecc0086bfc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/QtDialog/QCMake.cxx
View File

@@ -486,7 +486,7 @@ void QCMake::setWarnUnusedMode(bool value)
void QCMake::checkOpenPossible() void QCMake::checkOpenPossible()
{ {
auto data = this->BinaryDirectory.toLocal8Bit().data(); std::string data = this->BinaryDirectory.toLocal8Bit().data();
auto possible = this->CMakeInstance->Open(data, true); auto possible = this->CMakeInstance->Open(data, true);
emit openPossible(possible); emit openPossible(possible);
} }