Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-15 20:46:37 +08:00
Code Issues Projects Releases Wiki Activity

CTest: Handle non-coverage lines in gcov files

Browse Source 
This implements a TODO in gcov file handling.
This commit is contained in:
Tobias Ellinghaus
2020-05-29 16:08:47 +02:00
parent 9656a0f55a
commit ed6d20ddcb
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Source/CTest/cmCTestCoverageHandler.cxx
View File

@@ -1215,8 +1215,6 @@ int cmCTestCoverageHandler::HandleGCovCoverage(
while (cmSystemTools::GetLineFromStream(ifile, nl)) { while (cmSystemTools::GetLineFromStream(ifile, nl)) {
cnt++; cnt++;
// TODO: Handle gcov 3.0 non-coverage lines
// Skip empty lines // Skip empty lines
if (nl.empty()) { if (nl.empty()) {
continue; continue;
@@ -1227,6 +1225,14 @@ int cmCTestCoverageHandler::HandleGCovCoverage(
continue; continue;
} }
// Handle gcov 3.0 non-coverage lines
// non-coverage lines seem to always start with something not
// a space and don't have a ':' in the 9th position
// TODO: Verify that this is actually a robust metric
if (nl[0] != ' ' && nl[9] != ':') {
continue;
}
// Read the coverage count from the beginning of the gcov output // Read the coverage count from the beginning of the gcov output
// line // line
std::string prefix = nl.substr(0, 12); std::string prefix = nl.substr(0, 12);