Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-16 22:37:30 +08:00
Code Issues Projects Releases Wiki Activity

source: Pass cmStringRange by value

Browse Source
This commit is contained in:
Daniel Pfeifer
2025-07-15 18:24:58 +02:00
committed by Brad King
parent 0c4040057a
commit fa0e5906ff
8 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/cmCoreTryCompile.cxx
View File

@@ -236,7 +236,7 @@ ArgumentParser::Continue cmCoreTryCompile::Arguments::SetSourceType(
} }
Arguments cmCoreTryCompile::ParseArgs( Arguments cmCoreTryCompile::ParseArgs(
cmRange<std::vector<std::string>::const_iterator> const& args, cmRange<std::vector<std::string>::const_iterator> args,
cmArgumentParser<Arguments> const& parser, cmArgumentParser<Arguments> const& parser,
std::vector<std::string>& unparsedArguments) std::vector<std::string>& unparsedArguments)
{ {

7
Source/cmCoreTryCompile.h
View File

@@ -161,8 +161,7 @@ private:
std::string WriteSource(std::string const& name, std::string const& content, std::string WriteSource(std::string const& name, std::string const& content,
char const* command) const; char const* command) const;
Arguments ParseArgs( Arguments ParseArgs(cmRange<std::vector<std::string>::const_iterator> args,
cmRange<std::vector<std::string>::const_iterator> const& args, cmArgumentParser<Arguments> const& parser,
cmArgumentParser<Arguments> const& parser, std::vector<std::string>& unparsedArguments);
std::vector<std::string>& unparsedArguments);
}; };

3
Source/cmDebuggerVariablesHelper.cxx
View File

@@ -83,8 +83,7 @@ std::shared_ptr<cmDebuggerVariables> cmDebuggerVariablesHelper::CreateIfAny(
std::shared_ptr<cmDebuggerVariables> cmDebuggerVariablesHelper::CreateIfAny( std::shared_ptr<cmDebuggerVariables> cmDebuggerVariablesHelper::CreateIfAny(
std::shared_ptr<cmDebuggerVariablesManager> const& variablesManager, std::shared_ptr<cmDebuggerVariablesManager> const& variablesManager,
std::string const& name, bool supportsVariableType, std::string const& name, bool supportsVariableType, cmBTStringRange entries)
cmBTStringRange const& entries)
{ {
if (entries.empty()) { if (entries.empty()) {
return {}; return {};

2
Source/cmDebuggerVariablesHelper.h
View File

@@ -48,7 +48,7 @@ public:
static std::shared_ptr<cmDebuggerVariables> CreateIfAny( static std::shared_ptr<cmDebuggerVariables> CreateIfAny(
std::shared_ptr<cmDebuggerVariablesManager> const& variablesManager, std::shared_ptr<cmDebuggerVariablesManager> const& variablesManager,
std::string const& name, bool supportsVariableType, std::string const& name, bool supportsVariableType,
cmBTStringRange const& entries); cmBTStringRange entries);
static std::shared_ptr<cmDebuggerVariables> CreateIfAny( static std::shared_ptr<cmDebuggerVariables> CreateIfAny(
std::shared_ptr<cmDebuggerVariablesManager> const& variablesManager, std::shared_ptr<cmDebuggerVariablesManager> const& variablesManager,

2
Source/cmStringAlgorithms.cxx
View File

@@ -230,7 +230,7 @@ std::string cmJoin(std::vector<std::string> const& rng,
return cmJoinStrings(rng, separator, initial); return cmJoinStrings(rng, separator, initial);
} }
std::string cmJoin(cmStringRange const& rng, cm::string_view separator, std::string cmJoin(cmStringRange rng, cm::string_view separator,
cm::string_view initial) cm::string_view initial)
{ {
return cmJoinStrings(rng, separator, initial); return cmJoinStrings(rng, separator, initial);

2
Source/cmStringAlgorithms.h
View File

@@ -126,7 +126,7 @@ std::string cmJoinStrings(Range const& rng, cm::string_view separator,
std::string cmJoin(std::vector<std::string> const& rng, std::string cmJoin(std::vector<std::string> const& rng,
cm::string_view separator, cm::string_view initial = {}); cm::string_view separator, cm::string_view initial = {});
std::string cmJoin(cmStringRange const& rng, cm::string_view separator, std::string cmJoin(cmStringRange rng, cm::string_view separator,
cm::string_view initial = {}); cm::string_view initial = {});
enum class cmTokenizerMode enum class cmTokenizerMode

5
Source/cmTarget.cxx
View File

@@ -1626,7 +1626,7 @@ std::set<std::string> const& cmTarget::GetSystemIncludeDirectories() const
} }
void cmTarget::AddInstallIncludeDirectories(cmTargetExport const& te, void cmTarget::AddInstallIncludeDirectories(cmTargetExport const& te,
cmStringRange const& incs) cmStringRange incs)
{ {
std::copy( std::copy(
incs.begin(), incs.end(), incs.begin(), incs.end(),
@@ -2403,8 +2403,7 @@ bool CheckLinkLibraryPattern(UsageRequirementProperty const& usage,
} }
} }
void cmTarget::FinalizeTargetConfiguration( void cmTarget::FinalizeTargetConfiguration(cmBTStringRange compileDefinitions)
cmBTStringRange const& compileDefinitions)
{ {
if (this->GetType() == cmStateEnums::GLOBAL_TARGET) { if (this->GetType() == cmStateEnums::GLOBAL_TARGET) {
return; return;

4
Source/cmTarget.h
View File

@@ -272,7 +272,7 @@ public:
void InsertPrecompileHeader(BT<std::string> const& entry); void InsertPrecompileHeader(BT<std::string> const& entry);
void AppendBuildInterfaceIncludes(); void AppendBuildInterfaceIncludes();
void FinalizeTargetConfiguration(cmBTStringRange const& compileDefinitions); void FinalizeTargetConfiguration(cmBTStringRange compileDefinitions);
std::string GetDebugGeneratorExpressions(std::string const& value, std::string GetDebugGeneratorExpressions(std::string const& value,
cmTargetLinkLibraryType llt) const; cmTargetLinkLibraryType llt) const;
@@ -281,7 +281,7 @@ public:
std::set<std::string> const& GetSystemIncludeDirectories() const; std::set<std::string> const& GetSystemIncludeDirectories() const;
void AddInstallIncludeDirectories(cmTargetExport const& te, void AddInstallIncludeDirectories(cmTargetExport const& te,
cmStringRange const& incs); cmStringRange incs);
cmStringRange GetInstallIncludeDirectoriesEntries( cmStringRange GetInstallIncludeDirectoriesEntries(
cmTargetExport const& te) const; cmTargetExport const& te) const;