OpenVPN/openvpn
1
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2025-05-09 21:51:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Check for errors in the return value of GetModuleFileNameW()

Browse Source 
Also replace MAX_PATH by _countof(openvpnpath) as the latter
is arguably more robust.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1494800196-8144-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14654.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
This commit is contained in:
Selva Nair 2017-05-14 18:16:36 -04:00 committed by Gert Doering
parent 3902e56a87
commit c18802e2e2
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/openvpn/win32.c
View File

@ -1271,7 +1271,12 @@ win_wfp_block_dns (const NET_IFINDEX index)
dmsg (D_LOW, "Tap Luid: %I64d", tapluid.Value);
/* Get OpenVPN path. */
GetModuleFileNameW(NULL, openvpnpath, MAX_PATH);
status = GetModuleFileNameW(NULL, openvpnpath, _countof(openvpnpath));
if (status == 0 || status == _countof(openvpnpath))
{
msg(M_WARN|M_ERRNO, "block_dns: failed to get executable path");
goto err;
}
if (FwpmGetAppIdFromFileName0(openvpnpath, &openvpnblob) != ERROR_SUCCESS)
goto err;