OpenVPN/openvpn
1
0
Fork 0
mirror of https://github.com/OpenVPN/openvpn.git synced 2025-05-09 13:41:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix 2 memory leaks in proxy authentication routine

Browse Source 
Signed-off-by: Guido Vranken <guidovranken@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <CAO5O-EL11jDxO+c1Gu0FvunqwUTW2uxjy910+A-s63Nr5O3NWw@mail.gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14758.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 8d606cd3f6bce304874b1d7745d40d11f64ea17d)
(cherry picked from commit a95927638f8ee5e14e7ac8845b20c5350cefc9b8)
This commit is contained in:
Guido Vranken 2017-06-08 16:36:54 +02:00 committed by Gert Doering
parent 23d632de5d
commit ce0f075c2c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proxy.c
View File

@ -273,6 +273,7 @@ get_proxy_authenticate (socket_descriptor_t sd,
{ {
if (!recv_line (sd, buf, sizeof (buf), timeout, true, NULL, signal_received)) if (!recv_line (sd, buf, sizeof (buf), timeout, true, NULL, signal_received))
{ {
free(*data);
*data = NULL; *data = NULL;
return HTTP_AUTH_NONE; return HTTP_AUTH_NONE;
} }
@ -850,6 +851,7 @@ establish_http_proxy_passthru (struct http_proxy_info *p,
if (p->options.auth_retry == PAR_NCT && method == HTTP_AUTH_BASIC) if (p->options.auth_retry == PAR_NCT && method == HTTP_AUTH_BASIC)
{ {
msg (D_PROXY, "HTTP proxy: support for basic auth and other cleartext proxy auth methods is disabled"); msg (D_PROXY, "HTTP proxy: support for basic auth and other cleartext proxy auth methods is disabled");
free(pa);
goto error; goto error;
} }
p->auth_method = method; p->auth_method = method;