Fix more of uninitialized struct user_pass local vars

Not all of these touch uninitialzed members of the struct, but that
could change in future.

Change-Id: I71bc847b48da54b70f60ccd7c4521ec699daf9cb
Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20240909204829.10379-1-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29152.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit aa1dd09b5fc196499c84d2ef9b0c254ebb1745d8)
This commit is contained in:
Selva Nair 2024-09-09 16:48:29 -04:00 committed by Gert Doering
parent 9e1598de43
commit f9ab7edbeb
3 changed files with 3 additions and 1 deletions

View File

@ -452,6 +452,7 @@ check_send_auth_token(struct context *c)
}
struct user_pass up;
CLEAR(up);
strncpynt(up.username, multi->locked_username, sizeof(up.username));
generate_auth_token(&up, multi);

View File

@ -238,6 +238,7 @@ _pkcs11_openvpn_pin_prompt(
{
struct user_pass token_pass;
char prompt[1024];
CLEAR(token_pass);
(void)global_data;
(void)user_data;

View File

@ -96,7 +96,7 @@ socks_username_password_auth(struct socks_proxy_info *p,
ssize_t size;
bool ret = false;
creds.defined = 0;
CLEAR(creds);
if (!get_user_pass(&creds, p->authfile, UP_TYPE_SOCKS, GET_USER_PASS_MANAGEMENT))
{
msg(M_NONFATAL, "SOCKS failed to get username/password.");