From 46f77a632d09817692d293612ca45d38231b034c Mon Sep 17 00:00:00 2001 From: Huang Qi Date: Fri, 10 Jan 2025 23:36:47 +0800 Subject: [PATCH] examples/usbserial: Fix style issues in host.c - Break long preprocessor conditionals across multiple lines - Add spaces around operators for better readability - Reformat long string literals to fit within line length limits - Improve consistency in spacing around parentheses and brackets Signed-off-by: Huang Qi --- examples/usbserial/host.c | 130 ++++++++++++++++++++------------------ 1 file changed, 70 insertions(+), 60 deletions(-) diff --git a/examples/usbserial/host.c b/examples/usbserial/host.c index c479c4491..0e29ff525 100644 --- a/examples/usbserial/host.c +++ b/examples/usbserial/host.c @@ -38,14 +38,17 @@ * Pre-processor Definitions ****************************************************************************/ -#if defined(CONFIG_EXAMPLES_USBSERIAL_INONLY) && defined(CONFIG_EXAMPLES_USBSERIAL_OUTONLY) +#if defined(CONFIG_EXAMPLES_USBSERIAL_INONLY) && \ + defined(CONFIG_EXAMPLES_USBSERIAL_OUTONLY) # error "Cannot define both CONFIG_EXAMPLES_USBSERIAL_INONLY and _OUTONLY" #endif -#if defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) && defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) +#if defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) && \ + defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) # error "Cannot define both CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL and _ONLYBIG" #endif -#if !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) && !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) +#if !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) && \ + !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) # ifndef CONFIG_EXAMPLES_USBSERIAL_INONLY # define COUNTER_NEEDED 1 # endif @@ -70,56 +73,60 @@ static const char g_shortmsg[] = "Sure... You betcha!!\n"; #ifndef CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL static const char g_longmsg[] = - "I am proud to come to this city as the guest of your distinguished Mayor, " - "who has symbolized throughout the world the fighting spirit of West Berlin. " - "And I am proud to visit the Federal Republic with your distinguished Chancellor " - "who for so many years has committed Germany to democracy and freedom and " - "progress, and to come here in the company of my fellow American, General Clay, " - "who has been in this city during its great moments of crisis and will come " - "again if ever needed.\n" - "Two thousand years ago the proudest boast was \"civis Romanus sum.\" Today, " - "in the world of freedom, the proudest boast is \"Ich bin ein Berliner.\"\r\"" - "I appreciate my interpreter translating my German!\n" - "There are many people in the world who really don't understand, or say they " - "don't, what is the great issue between the free world and the Communist world. " - "Let them come to Berlin. There are some who say that communism is the wave of " - "the future. Let them come to Berlin. And there are some who say in Europe and " - "elsewhere we can work with the Communists. Let them come to Berlin. And there " - "are even a few who say that it is true that communism is an evil system, but it " - "permits us to make economic progress. Lass' sie nach Berlin kommen. Let them " - "come to Berlin.\n" - "Freedom has many difficulties and democracy is not perfect, but we have never " - "had to put a wall up to keep our people in, to prevent them from leaving us. I " - "want to say, on behalf of my countrymen, who live many miles away on the other " - "side of the Atlantic, who are far distant from you, that they take the greatest " - "pride that they have been able to share with you, even from a distance, the " - "story of the last 18 years. I know of no town, no city, that has been besieged " - "for 18 years that still lives with the vitality and the force, and the hope and " - "the determination of the city of West Berlin. While the wall is the most obvious " - "and vivid demonstration of the failures of the Communist system, for all the " - "world to see, we take no satisfaction in it, for it is, as your Mayor has said, " - "an offense not only against history but an offense against humanity, separating " - "families, dividing husbands and wives and brothers and sisters, and dividing a " - "people who wish to be joined together.\n" - "What is true of this city is true of Germany--real, lasting peace in Europe can " - "never be assured as long as one German out of four is denied the elementary " - "right of free men, and that is to make a free choice. In 18 years of peace and " - "good faith, this generation of Germans has earned the right to be free, " - "including the right to unite their families and their nation in lasting peace, " - "with good will to all people. You live in a defended island of freedom, but " - "your life is part of the main. So let me ask you as I close, to lift your eyes " - "beyond the dangers of today, to the hopes of tomorrow, beyond the freedom merely " - "of this city of Berlin, or your country of Germany, to the advance of freedom " - "everywhere, beyond the wall to the day of peace with justice, beyond yourselves " - "and ourselves to all mankind.\n" - "Freedom is indivisible, and when one man is enslaved, all are not free. When all " - "are free, then we can look forward to that day when this city will be joined as " - "one and this country and this great Continent of Europe in a peaceful and hopeful " - "globe. When that day finally comes, as it will, the people of West Berlin can take " - "sober satisfaction in the fact that they were in the front lines for almost two " - "decades.\n" - "All free men, wherever they may live, are citizens of Berlin, and, therefore, " - "as a free man, I take pride in the words \"Ich bin ein Berliner.\"\n" + "I am proud to come to this city as the guest of your distinguished " + "Mayor, who has symbolized throughout the world the fighting spirit of " + "West Berlin. And I am proud to visit the Federal Republic with your " + "distinguished Chancellor who for so many years has committed Germany " + "to democracy and freedom and progress, and to come here in the company " + "of my fellow American, General Clay, who has been in this city during " + "its great moments of crisis and will come again if ever needed.\n" + "Two thousand years ago the proudest boast was \"civis Romanus sum.\" " + "Today, in the world of freedom, the proudest boast is " + "\"Ich bin ein Berliner.\"\r\"I appreciate my interpreter translating " + "my German!\nThere are many people in the world who really " + "don't understand, or say they don't, what is the great issue between " + "the free world and the Communist world. Let them come to Berlin. " + "There are some who say that communism is the wave of the future. " + "Let them come to Berlin. And there are some who say in Europe and " + "elsewhere we can work with the Communists. Let them come to Berlin. " + "And there are even a few who say that it is true that communism is " + "an evil system, but it permits us to make economic progress. " + "Lass' sie nach Berlin kommen. Let them come to Berlin.\n" + "Freedom has many difficulties and democracy is not perfect, but we have " + "never had to put a wall up to keep our people in, to prevent them from " + "leaving us. I want to say, on behalf of my countrymen, who live many " + "miles away on the other side of the Atlantic, who are far distant " + "from you, that they take the greatest pride that they have been able " + "to share with you, even from a distance, the story of the last 18 years. " + "I know of no town, no city, that has been besieged for 18 years that " + "still lives with the vitality and the force, and the hope and the " + "determination of the city of West Berlin. While the wall is the most " + "obvious and vivid demonstration of the failures of the Communist system, " + "for all the world to see, we take no satisfaction in it, for it is, " + "as your Mayor has said, an offense not only against history but an " + "offense against humanity, separating families, dividing husbands and " + "wives and brothers and sisters, and dividing a people who wish to be " + "joined together.\nWhat is true of this city is true of Germany--real, " + "lasting peace in Europe can never be assured as long as one German " + "out of four is denied the elementary right of free men, and that is " + "to make a free choice. In 18 years of peace and good faith, this " + "generation of Germans has earned the right to be free, including the " + "right to unite their families and their nation in lasting peace, " + "with good will to all people. You live in a defended island of freedom, " + "but your life is part of the main. So let me ask you as I close, to lift " + "your eyes beyond the dangers of today, to the hopes of tomorrow, beyond " + "the freedom merely of this city of Berlin, or your country of Germany, " + "to the advance of freedom everywhere, beyond the wall to the day of " + "peace with justice, beyond yourselves and ourselves to all mankind.\n" + "Freedom is indivisible, and when one man is enslaved, all are not free. " + "When all are free, then we can look forward to that day when this city " + "will be joined as one and this country and this great Continent of " + "Europe in a peaceful and hopeful globe. When that day finally comes, " + "as it will, the people of West Berlin can take sober satisfaction " + "in the fact that they were in the front lines for almost two decades.\n" + "All free men, wherever they may live, are citizens of Berlin, and, " + "therefore, as a free man, I take pride in the words " + "\"Ich bin ein Berliner.\"\n" "President John F. Kennedy - June 26, 1963\n"; #endif @@ -200,10 +207,11 @@ int main(int argc, char **argv, char **envp) return 1; } - tty.c_iflag &= ~(IGNBRK|BRKINT|PARMRK|ISTRIP|INLCR|IGNCR|ICRNL|IXON); + tty.c_iflag &= + ~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR | IGNCR | ICRNL | IXON); tty.c_oflag &= ~OPOST; - tty.c_lflag &= ~(ECHO|ECHONL|ICANON|ISIG|IEXTEN); - tty.c_cflag &= ~(CSIZE|PARENB); + tty.c_lflag &= ~(ECHO | ECHONL | ICANON | ISIG | IEXTEN); + tty.c_cflag &= ~(CSIZE | PARENB); tty.c_cflag |= CS8; ret = tcsetattr(fd, TCSANOW, &tty); @@ -217,14 +225,14 @@ int main(int argc, char **argv, char **envp) /* Wait for and/or send messages -- forever */ - for (;;) + for (; ; ) { /* Test IN messages (device-to-host) */ #ifndef CONFIG_EXAMPLES_USBSERIAL_OUTONLY printf("main: Reading from the serial driver\n"); printf("main: ... (Control-C to terminate) ...\n"); - nbytes = read(fd, g_iobuffer, BUFFER_SIZE-1); + nbytes = read(fd, g_iobuffer, BUFFER_SIZE - 1); if (nbytes < 0) { printf("main: ERROR: Failed to read from %s: %s\n", @@ -249,7 +257,8 @@ int main(int argc, char **argv, char **envp) /* Test OUT messages (host-to-device) */ #ifndef CONFIG_EXAMPLES_USBSERIAL_INONLY -#if !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) && !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) +#if !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) && \ + !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) count++; if (count < 5) { @@ -276,7 +285,8 @@ int main(int argc, char **argv, char **envp) if (nbytes < 0) { - printf("main: ERROR: Failed to write to %s: %s\n", g_ttydev, strerror(errno)); + printf("main: ERROR: Failed to write to %s: %s\n", g_ttydev, + strerror(errno)); close(fd); return 2; }