apache/nuttx-apps
1
0
Fork 0
mirror of https://github.com/apache/nuttx-apps.git synced 2025-10-19 11:23:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "This commit adds nsh_consolechild(). I noticed that there are several examples that call nsh_consolemain.c to create to create a new NSH session. That will not always work because nsh_consolemain() performs the one-time initialization needed by the NSH library: Mounting, reading, and running the start-up script, configuring USB tracing. Some of those actions will cause failures if attempted twice."

Browse Source 
This reverts commit 4d364d836a.
This commit is contained in:
Gregory Nutt
2016-08-25 14:19:36 -06:00
parent 4d364d836a
commit 4eda22b4db
5 changed files with 12 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
nshlib/nsh_consolemain.c
View File

@@ -55,19 +55,14 @@
* Name: nsh_consolemain (Normal character device version)
*
* Description:
* This interfaces may be to called or started with task_start to start a
* This interfaces maybe to called or started with task_start to start a
* single an NSH instance that operates on stdin and stdout. This
* function does not normally return (see below).
*
* This function performs all basic, one-time initialization logic as
* configured. This includes such things as mounting the romfs /etc/
* file system and running the initialization script, setting up USB
* tracing options. It should be spawned only once for this reason.
*
* This version of nsh_consolmain() handles generic /dev/console character
* This version of nsh_consolmain handles generic /dev/console character
* devices (see nsh_usbconsole.c and usb_usbkeyboard for other versions
* for special USB console devices).
*
*
* Input Parameters:
* Standard task start-up arguments. These are not used. argc may be
* zero and argv may be NULL.
@@ -84,17 +79,17 @@ int nsh_consolemain(int argc, char *argv[])
FAR struct console_stdio_s *pstate = nsh_newconsole();
int ret;
DEBUGASSERT(pstate != NULL);
DEBUGASSERT(pstate);
#ifdef CONFIG_NSH_ROMFSETC
/* Execute the start-up script */
#ifdef CONFIG_NSH_ROMFSETC
(void)nsh_initscript(&pstate->cn_vtbl);
#endif
#ifdef CONFIG_NSH_USBDEV_TRACE
/* Initialize any USB tracing options that were requested */
#ifdef CONFIG_NSH_USBDEV_TRACE
usbtrace_enable(TRACE_BITSET);
#endif