apache/nuttx-apps
1
0
Fork 0
mirror of https://github.com/apache/nuttx-apps.git synced 2025-10-19 19:44:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

nshlib: Fix nxstyle warning

Browse Source 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
This commit is contained in:
Xiang Xiao
2020-04-17 11:45:51 +08:00
committed by patacongo
parent de8a56d149
commit 650b58d6b2
13 changed files with 99 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
nshlib/nsh_usbconsole.c
View File

@@ -89,9 +89,10 @@ static void nsh_configstdio(int fd)
dup2(fd, 1);
dup2(fd, 2);
/* fdopen to get the stdin, stdout and stderr streams. The following logic depends
* on the fact that the library layer will allocate FILEs in order. And since
* we closed stdin, stdout, and stderr above, that is what we should get.
/* fdopen to get the stdin, stdout and stderr streams. The following logic
* depends on the fact that the library layer will allocate FILEs in order.
* And since we closed stdin, stdout, and stderr above, that is what we
* should get.
*
* fd = 0 is stdin (read-only)
* fd = 1 is stdout (write-only, append)
@@ -129,9 +130,9 @@ static int nsh_nullstdio(void)
*/
if (fd > 2)
{
{
close(fd);
}
}
return OK;
}
@@ -171,8 +172,8 @@ restart:
fd = open(CONFIG_NSH_USBCONDEV, O_RDWR);
if (fd < 0)
{
/* ENOTCONN means that the USB device is not yet connected. Anything
* else is bad.
/* ENOTCONN means that the USB device is not yet connected.
* Anything else is bad.
*/
DEBUGASSERT(errno == ENOTCONN);
@@ -230,7 +231,7 @@ restart:
nsh_configstdio(fd);
/* We can close the original file descriptor now (unless it was one of 0-2) */
/* We can close the original file descriptor (unless it was one of 0-2) */
if (fd > 2)
{
@@ -257,7 +258,7 @@ restart:
* operations to handle the cases where the session is lost when the
* USB device is unplugged and restarted when the USB device is plugged
* in again.
*
*
* Input Parameters:
* Standard task start-up arguments. These are not used. argc may be
* zero and argv may be NULL.
@@ -268,7 +269,7 @@ restart:
*
****************************************************************************/
int nsh_consolemain(int argc, char *argv[])
int nsh_consolemain(int argc, FAR char *argv[])
{
FAR struct console_stdio_s *pstate = nsh_newconsole();
struct boardioc_usbdev_ctrl_s ctrl;
@@ -327,7 +328,7 @@ int nsh_consolemain(int argc, char *argv[])
/* Now loop, executing creating a session for each USB connection */
for (;;)
for (; ; )
{
/* Wait for the USB to be connected to the host and switch
* standard I/O to the USB serial device.