apache/nuttx-apps
1
0
Fork 0
mirror of https://github.com/apache/nuttx-apps.git synced 2025-10-20 21:41:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

nsh: Fix a potential buffer overflow in cmd help

Browse Source 
Follow https://github.com/apache/nuttx-apps/pull/1621, fix issue of builtin command list.

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
This commit is contained in:
Huang Qi
2023-03-08 20:56:16 +08:00
committed by Xiang Xiao
parent dd2c3b3f6a
commit dbf7d34a2a
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
nshlib/nsh_command.c
View File

@@ -813,7 +813,11 @@ static inline void help_builtins(FAR struct nsh_vtbl_s *vtbl)
unsigned int j; unsigned int j;
unsigned int k; unsigned int k;
unsigned int offset; unsigned int offset;
char line[HELP_LINELEN];
/* Extra 5 bytes for tab before newline and '\0' */
char line[HELP_LINELEN + HELP_TABSIZE + 1];
static const char *g_builtin_prompt = "\nBuiltin Apps:\n"; static const char *g_builtin_prompt = "\nBuiltin Apps:\n";
/* Count the number of built-in commands and get the optimal column width */ /* Count the number of built-in commands and get the optimal column width */