apache/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2025-05-08 22:32:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

net/can: Fix NULL dereference for I/O Block

Browse Source 
In a recent patch the socketcan timestamp generation was moved
to add it also when there is an active reader (previously the timestamp
was only added before storing the CAN frame in the read-ahead list).

It was working fine but I realized that the can_callback function is
also called when sending frames. In this case, the IO block is not allocated
yet and the code breaks.

This PR is to only generate the timestamp if the IO block is not NULL
(reading path) and skip it when it is NULL (sending path)

Signed-off-by: Javier Casas <javiercasas@geotab.com>
This commit is contained in:
Javier Casas 2025-03-10 17:43:19 +01:00 committed by Alin Jerpelea
parent 96eb5e7819
commit 9c04b9ed4a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/can/can_callback.c
View File

@ -124,7 +124,8 @@ uint16_t can_callback(FAR struct net_driver_s *dev,
* create timestamp and copy to iob
*/
if (_SO_GETOPT(conn->sconn.s_options, SO_TIMESTAMP))
if (_SO_GETOPT(conn->sconn.s_options, SO_TIMESTAMP) &&
(dev->d_iob != NULL))
{
struct timeval tv;
FAR struct timespec *ts = (FAR struct timespec *)&tv;