dwarf_tsearch implementation.
Fixed a small memory curruption in dwarfdump2/print_pubnames.cc
Added tsearch directory with various sorts of tree searches
(all written from scratch, not copied from anywhere).
* dwarfdump.c: Change // comments to /* */ comments.
* makename.c: Delete blank line and trailing space. Add cast
so gcc -ansi compiles without complaint.
* print_die.c, uri.c: Change // comments to /* */ comments.
* tag_attr.c: Add getopt.h include so gcc -ansi compiles
without complaint.
* tag_tree.c: Add getopt.h and string.h include so gcc -ansi compiles
without complaint. Add cast so strdup call to avoid warning.
* addr_map.c: Add cast so strdup call does not cause warning gcc -ansi.
we have tsearch but not tdestroy() we use tsearch and let
it dwarfdump leak memory. tdestroy() without tsearch()
makes no sense (how could that arise?).
We only have both in GNU libc.
dwarfdump2 has no such memory leak, it uses C++ facilities
instead of tsearch().
change to make consistent use of 'if', 'for' and 'while'.
===================
dwarfdump.c lines 73-78 Any time an 'extern foo' appears in a .c or a .cc
file it represents a current or future error that cannot be easily detected
at compile time. Bad.
Instead, put print_attributes_encoding and current_cu_die_for_print_frames
declarations into appropriate .h files (possibly new one or ones?) and
include the header in each .c/.cc where it is needed. That prevents future
spelling errors from causing mysterious runtime failures due to argument
errors: the compiler will catch argument errors.
Now line 56-58 is special in that it refers to some windows thing, not
defined in dwarfdump. So that one perhaps should or must stay as written.
===================
dwarfdump.c line 549: the variable 'bitmap' should be named something else.
bitmap is just too generic, not helpful to the reader. Easier for a
reviewer to see this sort of issue than the author :-)
Possibly local_section_bitmap? Somehow get 'section' in there in that
function-argument-name?
=======
dwarfdump.c: good catch on the indent errors in qsort_compare_compiler(),
I have no idea how I failed to run dicheck on that.
======
dwarfdump.c line 1043. The 'Just for the moment' comment is odd. What
does that mean? Why 'for the moment'? I am not going to try to guess
why you did that, but it has to be somehow wrong?
Either the code or the comment?
========
dwarfdump.c line 1162. The comment says do not do reloc_flag = TRUE
yet you added exactly that! Yikes! I don't know what to do about
this, but something has to change. Comment or statement. Can we detect
non-elf somehow? We probably already do, but...
===================
dwarfdump.c line 1630. Oops. Good catch on removing the mistaken extra
break;
