bugxml/data.txt
Fix indents, remove trailing whitespace.
dwarfdump/print_abbrevs.c
dwarfdump/print_aranges.c
dwarfdump/print_frames.c
dwarfdump/print_sections.c
Ensure we check dwarf functtion status return.
These sources used only at build time.
dwarfdump/tag_attr.c
dwarfdump/tag_tree.c
Moved a couple functions between source files
and made them static. A couple commentary changes.
print_frames.c, though, needed hardening against
corrupt frame data.
dwarfdump/globals.h
dwarfdump/print_aranges.c
dwarfdump/print_die.c
dwarfdump/print_frames.c
dwarfdump/print_sections.c
All data reads from an object ensure the
read is actually in a section.
It is always possible something was overlooked, but
all the reading macros and functions now do checks.
libdwarf/dwarf_arange.c
libdwarf/dwarf_die_deliv.c
libdwarf/dwarf_errmsg_list.c
libdwarf/dwarf_form.c
libdwarf/dwarf_frame.c
libdwarf/dwarf_frame2.c
libdwarf/dwarf_global.c
libdwarf/dwarf_line.c
libdwarf/dwarf_line_table_reader_common.c
libdwarf/dwarf_loc.c
libdwarf/dwarf_loc2.c
libdwarf/dwarf_macro5.c
libdwarf/dwarf_opaque.h
libdwarf/dwarf_print_lines.c
libdwarf/dwarf_query.c
libdwarf/dwarf_ranges.c
libdwarf/dwarf_util.c
libdwarf/dwarf_util.h
libdwarf/dwarf_xu_index.c
libdwarf/libdwarf.h.in
dwarfdump/globals.h
dwarfdump/print_aranges.c
dwarfdump/print_die.c
dwarfdump/print_frames.c
dwarfdump/print_lines.c
dwarfdump/print_macro.c
dwarfdump/print_pubnames.c
print_lines.c,print_macro.c,print_pubnames.c:
Remove the global dieprint_cu_offset, use local vars and pass around instead.
Ensure the traverse() logic when checking type references do not evaluate
references to other sections. Many argument lists got an additional argument or two.
libdwarf/dwarf_form.c
fix a comment
print_frames.c,print_lines.c,print_locs.c,print_macro.c,
print_pubnames.c,print_reloc.ckprint_static_funcs.c,
print_static_vars.c,print_strings.c,print_types.c,
print_weaknames.c: Removed global Dwarf_Error err
and provided local Dwarf_Error as needed.
libdwarf2.1.mm: Added dwarf_lineoff_b() documentation.
Fixed a typo in dwarf_formexprloc() documentation.
libdwarf2.1.pdf: Regenerated. Version 2.41
shown by dwarfdump.
dwarfdump/dwarfdump.1
Now we get the real section names from
libdwarf.
dwarfdump/print_aranges.c
dwarfdump/print_die.c
dwarfdump/print_lines.c
dwarfdump/print_ranges.c
dwarfdump/print_strings.c
Add functions to get the true
section names.
libdwarf/dwarf_die_deliv.c
libdwarf/dwarf_line.c
libdwarf/libdwarf.h.in
Document the new functions. Version 2.35
libdwarf/libdwarf2.1.mm
Regenerate.
libdwarf/libdwarf2.1.pdf
1) Improve the '-S' option algorithm, to get indirect names, from
DW_AT_specification and DW_AT_abstract_origin attributes, to use
those names in the comparison for member and inlines functions.
2) Correct incorrect calculation of 'pointer_size' for proprietary
EM_PPC64 machine type.
3) Changes required when porting the samples to Windows
4) Include additional information for the Windows version.
change to make consistent use of 'if', 'for' and 'while'.
===================
dwarfdump.c lines 73-78 Any time an 'extern foo' appears in a .c or a .cc
file it represents a current or future error that cannot be easily detected
at compile time. Bad.
Instead, put print_attributes_encoding and current_cu_die_for_print_frames
declarations into appropriate .h files (possibly new one or ones?) and
include the header in each .c/.cc where it is needed. That prevents future
spelling errors from causing mysterious runtime failures due to argument
errors: the compiler will catch argument errors.
Now line 56-58 is special in that it refers to some windows thing, not
defined in dwarfdump. So that one perhaps should or must stay as written.
===================
dwarfdump.c line 549: the variable 'bitmap' should be named something else.
bitmap is just too generic, not helpful to the reader. Easier for a
reviewer to see this sort of issue than the author :-)
Possibly local_section_bitmap? Somehow get 'section' in there in that
function-argument-name?
=======
dwarfdump.c: good catch on the indent errors in qsort_compare_compiler(),
I have no idea how I failed to run dicheck on that.
======
dwarfdump.c line 1043. The 'Just for the moment' comment is odd. What
does that mean? Why 'for the moment'? I am not going to try to guess
why you did that, but it has to be somehow wrong?
Either the code or the comment?
========
dwarfdump.c line 1162. The comment says do not do reloc_flag = TRUE
yet you added exactly that! Yikes! I don't know what to do about
this, but something has to change. Comment or statement. Can we detect
non-elf somehow? We probably already do, but...
===================
dwarfdump.c line 1630. Oops. Good catch on removing the mistaken extra
break;
DavidAnderson <davea42@earthlink.net>
* checkutil.c (ProcessBucketGroup): Deleted unused
local variables.
* common.c: Updated version string.
* dwarfdump.1: Made the -k discussion more complete and accurate.
Most option details are in the dwarfdump help/usage message, not
in dwarfdump.1, to keep the man page small.
* dwarfdump.c: Updated version string. Made more variables static
in recognition they are only touched in this file. Added {} on
some if statements to make the body clear. Parenthesized a
complex test with && || to clarify intent. Added sanity testing
of the 'current compiler' count and its use.
* globals.h: Added safe_strcpy() prototype as it is used by multiple
source files so we need a visible prototype.
* print_aranges.c: Add 'arange end' printing (it is a real DWARF
record type, so should be printed). Add a test to avoid duplicated
die printing and error-counting when it is not requested.
* print_die.c: An = in an if corrected to ==. Parenthesized a
complex test with && || to clarify intent. Deleted an unused
local variable.
* print_lines.c: Deleted unused local variables. Added {} for each
struct in an array so the initialization gets done right.
* tag_attr.c: Deleted an unused local variable.
* tag_tree.c: Deleted an unused local variable.
dwarfdump2
2010-06-04 DavidAnderson <davea42@earthlink.net>
* dwarfdump.cc: Updated DWARF_VERSION string.
