bugxml/data.txt
Fix indents, remove trailing whitespace.
dwarfdump/print_abbrevs.c
dwarfdump/print_aranges.c
dwarfdump/print_frames.c
dwarfdump/print_sections.c
Ensure we check dwarf functtion status return.
These sources used only at build time.
dwarfdump/tag_attr.c
dwarfdump/tag_tree.c
and just use char*.
Ensure the getopt tests still work.
modified: dwarfdump/dwarfdump.c
modified: dwarfdump/dwgetopt.c
modified: dwarfdump/esb.c
modified: dwarfdump/esb.h
modified: dwarfdump/getopttest.c
modified: dwarfdump/globals.h
modified: dwarfdump/print_die.c
modified: dwarfdump/print_frames.c
modified: dwarfdump/print_lines.c
modified: dwarfdump/print_strings.c
modified: dwarfdump/tag_attr.c
modified: dwarfdump/tag_tree.c
Fixing errnumber->string array and arranging
that we test it during build.
modified: libdwarf/Makefile.in
renamed: libdwarf/dwarf_error.c -> libdwarf/dwarf_errmsg_list.c
modified: libdwarf/dwarf_error.c
* tag_tree_ext.list, tag_attr_ext.list: Include support for variadic
templates (GCC extension) DW_TAG_GNU_template_parameter_pack,
DW_TAG_GNU_formal_parameter_pack. These extensions are
generated by LLVM
* tag_tree.c: Incorrect generated comment
* tag_common.h: Update table size for new added tag/attr checks
so all is easier for those without getopt() to build.
To avoid unwanted dependencies dwgetopt.h and dwgetopt.c
are in both dwarfdump and libdwarf directories.
* dwarfdump.c: Change // comments to /* */ comments.
* makename.c: Delete blank line and trailing space. Add cast
so gcc -ansi compiles without complaint.
* print_die.c, uri.c: Change // comments to /* */ comments.
* tag_attr.c: Add getopt.h include so gcc -ansi compiles
without complaint.
* tag_tree.c: Add getopt.h and string.h include so gcc -ansi compiles
without complaint. Add cast so strdup call to avoid warning.
* addr_map.c: Add cast so strdup call does not cause warning gcc -ansi.
change to make consistent use of 'if', 'for' and 'while'.
===================
dwarfdump.c lines 73-78 Any time an 'extern foo' appears in a .c or a .cc
file it represents a current or future error that cannot be easily detected
at compile time. Bad.
Instead, put print_attributes_encoding and current_cu_die_for_print_frames
declarations into appropriate .h files (possibly new one or ones?) and
include the header in each .c/.cc where it is needed. That prevents future
spelling errors from causing mysterious runtime failures due to argument
errors: the compiler will catch argument errors.
Now line 56-58 is special in that it refers to some windows thing, not
defined in dwarfdump. So that one perhaps should or must stay as written.
===================
dwarfdump.c line 549: the variable 'bitmap' should be named something else.
bitmap is just too generic, not helpful to the reader. Easier for a
reviewer to see this sort of issue than the author :-)
Possibly local_section_bitmap? Somehow get 'section' in there in that
function-argument-name?
=======
dwarfdump.c: good catch on the indent errors in qsort_compare_compiler(),
I have no idea how I failed to run dicheck on that.
======
dwarfdump.c line 1043. The 'Just for the moment' comment is odd. What
does that mean? Why 'for the moment'? I am not going to try to guess
why you did that, but it has to be somehow wrong?
Either the code or the comment?
========
dwarfdump.c line 1162. The comment says do not do reloc_flag = TRUE
yet you added exactly that! Yikes! I don't know what to do about
this, but something has to change. Comment or statement. Can we detect
non-elf somehow? We probably already do, but...
===================
dwarfdump.c line 1630. Oops. Good catch on removing the mistaken extra
break;
DavidAnderson <davea42@earthlink.net>
* checkutil.c (ProcessBucketGroup): Deleted unused
local variables.
* common.c: Updated version string.
* dwarfdump.1: Made the -k discussion more complete and accurate.
Most option details are in the dwarfdump help/usage message, not
in dwarfdump.1, to keep the man page small.
* dwarfdump.c: Updated version string. Made more variables static
in recognition they are only touched in this file. Added {} on
some if statements to make the body clear. Parenthesized a
complex test with && || to clarify intent. Added sanity testing
of the 'current compiler' count and its use.
* globals.h: Added safe_strcpy() prototype as it is used by multiple
source files so we need a visible prototype.
* print_aranges.c: Add 'arange end' printing (it is a real DWARF
record type, so should be printed). Add a test to avoid duplicated
die printing and error-counting when it is not requested.
* print_die.c: An = in an if corrected to ==. Parenthesized a
complex test with && || to clarify intent. Deleted an unused
local variable.
* print_lines.c: Deleted unused local variables. Added {} for each
struct in an array so the initialization gets done right.
* tag_attr.c: Deleted an unused local variable.
* tag_tree.c: Deleted an unused local variable.
dwarfdump2
2010-06-04 DavidAnderson <davea42@earthlink.net>
* dwarfdump.cc: Updated DWARF_VERSION string.
