Compare commits

...

6 Commits

Author SHA1 Message Date
David Anderson
6c37ac5514 Up to date with git log, just now fixed
three issues found be CoverityScan.
	modified:   ChangeLog
2025-09-25 14:37:28 -07:00
David Anderson
d03b6e6775 CoverityScan issue 400783. Around lines 1382 and 1405
two return were missing the required
local_attrlist_dealloc(dbg,atcount,alist)
before the return.
	modified:   src/lib/libdwarf/dwarf_die_deliv.c
2025-09-25 14:33:05 -07:00
David Anderson
5620381de4 In all_srcfiles_create_entry() we could cause
a memory leak.  Coverity Scan issue 548972.
Reordered a couple lines of code to make
the leak impossible.
	modified:   src/bin/dwarfdump/dd_all_srcfiles.c
2025-09-25 14:31:22 -07:00
David Anderson
22a582ba74 coverity scan noticed dead code. Issue 548973.
The dead code was just a mistake in this
example program. Removed the lines testing INITIAL_VAL.
	modified:   src/bin/dwarfexample/frame1.c
2025-09-25 14:28:19 -07:00
David Anderson
d33c9bd168 Split a too-long line to two lines
to match project codingstandard.
	modified:   src/lib/libdwarf/dwarf_form.c
2025-09-25 14:26:36 -07:00
David Anderson
4b56aa6d22 When one or more build methods are not done
remark on that in the place we mention install
file counts per build method.
	modified:   scripts/allsimplebuilds.sh
2025-09-25 14:25:04 -07:00
6 changed files with 74 additions and 23 deletions

View File

@@ -1,3 +1,50 @@
2025-09-25: David Anderson
commit d03b6e67753f33b116b7bd3f2b2422988209aed7
CoverityScan issue 400783. Around lines 1382 and 1405
two return were missing the required
local_attrlist_dealloc(dbg,atcount,alist)
before the return.
modified: src/lib/libdwarf/dwarf_die_deliv.c
2025-09-25: David Anderson
commit 5620381de442ef7976e14ab703e5c210e3fc1d0e
In all_srcfiles_create_entry() we could cause
a memory leak. Coverity Scan issue 548972.
Reordered a couple lines of code to make
the leak impossible.
modified: src/bin/dwarfdump/dd_all_srcfiles.c
2025-09-25: David Anderson
commit 22a582ba74af7d4a65e07b656b31d375b9f57977
coverity scan noticed dead code. Issue 548973.
The dead code was just a mistake in this
example program. Removed the lines testing INITIAL_VAL.
modified: src/bin/dwarfexample/frame1.c
2025-09-25: David Anderson
commit d33c9bd168058200924cf7234514c434479c4808
Split a too-long line to two lines
to match project codingstandard.
modified: src/lib/libdwarf/dwarf_form.c
2025-09-25: David Anderson
commit 4b56aa6d220df233ef255e677fa4d89ea7621981
When one or more build methods are not done
remark on that in the place we mention install
file counts per build method.
modified: scripts/allsimplebuilds.sh
2025-09-25: David Anderson
commit 9c941c33e95263b8e4aa3e4157ca9ec5d03a2efc
Up to date with git log data.
modified: ChangeLog
2025-09-24: David Anderson
commit ab1ce3208ed2f7ac72d034deaab5d92c163198b4

View File

@@ -316,11 +316,15 @@ fi
for i in $tbase/allconfiguresharedinstalled $tbase/allconfigurestaticinstalled $tbase/allmesonsharedinstalled $tbase/allmesonstaticinstalled $tbase/allcmakesharedinstalled $tbase/allscmakestaticinstalled
do
cd $i
find . -type f -print >/tmp/x.$$
l=`wc -l < /tmp/x.$$`
echo "$i has $l files"
rm /tmp/x.$$
if [ -d $i ]
then
find . -type f -print >/tmp/x.$$
l=`wc -l < /tmp/x.$$`
echo "$i has $l files"
rm /tmp/x.$$
else
echo "Skip $i, it is not built."
fi
done
cd $spath
ndsecs=`date '+%s'`

View File

@@ -94,16 +94,17 @@ keyprint(const void *k)
static struct All_Srcfiles_Entry *
all_srcfiles_create_entry(char *key )
{
struct All_Srcfiles_Entry *mp =
(struct All_Srcfiles_Entry *)malloc(
struct All_Srcfiles_Entry *mp = 0;
if (!key) {
/* mistake somewhere */
return 0;
}
mp = (struct All_Srcfiles_Entry *)malloc(
sizeof(struct All_Srcfiles_Entry));
if (!mp) {
return 0;
}
if (!key) {
/* mistake somewhere */
return NULL;
}
mp->ase_srcfilename = (char *)strdup(key);
mp->ase_dupcount = 1;
return mp;

View File

@@ -80,7 +80,7 @@ static int stop_at_n_fdes = 0;
#define SAME_VAL DW_FRAME_SAME_VAL
#define CFA_VAL DW_FRAME_CFA_COL
/*#define INITIAL_VAL UNDEF_VAL */
#define INITIAL_VAL SAME_VAL
#define INITIAL_VAL SAME_VAL
/* Dumping a dwarf-expression as a byte stream. */
static void
@@ -129,11 +129,11 @@ main(int argc, char **argv)
if (!strncmp(argv[curopt],countstr,countstr_len)) {
char *carg = argv[curopt];
if (!carg[countstr_len]) {
printf("Improper %s arg, needs a number. Ignored\n",
carg);
printf("Improper %s arg, needs a number. Ignored\n",
carg);
} else {
stop_at_n_fdes = atoi((const char *)
(carg+countstr_len));
stop_at_n_fdes = atoi((const char *)
(carg+countstr_len));
}
}
if (!strcmp(argv[curopt],"--print-selected-regs")) {
@@ -372,9 +372,6 @@ print_fde_col(Dwarf_Signed k,
if (reg_used == SAME_VAL) {
printf(" SAME_VAL");
/* break; */
} else if (reg_used == INITIAL_VAL) {
printf(" INITIAL_VAL");
/*break; */
} else if (reg_used == UNDEF_VAL) {
printf(" UNDEF_VAL");
}
@@ -518,7 +515,7 @@ print_fde_selected_regs( Dwarf_Fde fde)
next_jsave = jsave+1;
printf("\n");
printf(" FDE columns (registers) for pc 0x%"
DW_PR_DUx "\n",jsave);
DW_PR_DUx "\n",jsave);
for (k = 0; k < selected_cols_count ; ++k ) {
Dwarf_Unsigned reg = 0;
Dwarf_Unsigned offset_relevant = 0;
@@ -877,7 +874,6 @@ print_reg(int r)
}
}
static char *
value_type_name(int valuetype,char *buf,unsigned buflen)
{
@@ -891,7 +887,7 @@ value_type_name(int valuetype,char *buf,unsigned buflen)
return "DW_EXPR_EXPRESSION";
case DW_EXPR_VAL_EXPRESSION:
return "DW_EXPR_VAL_EXPRESSION";
default:
default:
break;
}
snprintf(buf,buflen, "Unknown(%d)",valuetype);

View File

@@ -1382,6 +1382,7 @@ find_cu_die_base_fields(Dwarf_Debug dbg,
if (lres == DW_DLV_OK) {
cucon->cc_language_name = (Dwarf_Half)uval;
} else {
local_attrlist_dealloc(dbg,atcount,alist);
return lres;
}
if (cucon->cc_have_language_version) {
@@ -1405,6 +1406,7 @@ find_cu_die_base_fields(Dwarf_Debug dbg,
cucon->cc_language_version = uval;
cucon->cc_have_language_version = TRUE;
} else {
local_attrlist_dealloc(dbg,atcount,alist);
return lres;
}
if (cucon->cc_language_name) {

View File

@@ -1919,7 +1919,8 @@ _dwarf_extract_string_offset_via_str_offsets(Dwarf_Debug dbg,
Dwarf_Half version = 0;
Dwarf_Half padding = 0;
res = _dwarf_load_section(dbg, &dbg->de_debug_str_offsets,error);
res = _dwarf_load_section(dbg,
&dbg->de_debug_str_offsets,error);
if (res != DW_DLV_OK) {
return res;
}