Commit Graph

14 Commits

Author SHA1 Message Date
Paul Wankadia
8e719eef2f Print debug information during toolchain resolution.
Change-Id: I0785aa430af198635b9c4a193043a3798417acc8
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62375
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2024-01-16 19:51:36 +00:00
Paul Wankadia
95bb96b298 Register the local Python toolchain with highest priority.
Change-Id: I74f63bab5b0eab4296b1ed7dee9b98e76fdd3d64
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62374
Reviewed-by: Paul Wankadia <junyer@google.com>
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
2024-01-16 19:07:59 +00:00
Paul Wankadia
c644d9aaec Try to get things working again with Bazel 7.
Specifically, try passing `--platforms` as well as `--cpu`.
(The latter is going away eventually, but keep it for now.)

Change-Id: Id53ba7b91008c7b90b1e9d242a3eded3e65007b8
Reviewed-on: https://code-review.googlesource.com/c/re2/+/62370
Reviewed-by: Paul Wankadia <junyer@google.com>
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
2024-01-16 15:35:06 +00:00
Paul Wankadia
a807e8a3aa Revert "Make the extension work for Python 3.8+."
This reverts commit 3a9939d2ae.

Reason for revert: pybind11 doesn't support `Py_LIMITED_API`;
as per https://github.com/pybind/pybind11/issues/1755, it has
probably never worked and it will probably never work.

Change-Id: Ie603151d31ad07a77d469f0050270d416fe8d21b
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61872
Reviewed-by: Paul Wankadia <junyer@google.com>
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
2023-09-07 19:51:21 +00:00
Paul Wankadia
3a9939d2ae Make the extension work for Python 3.8+.
See https://docs.python.org/3/c-api/stable.html for background.

Accordingly, the build matrix no longer needs the Python version.

Change-Id: I36c0f0c399c54e1ea06011bbe1d4aa8afef4cf05
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61871
Reviewed-by: Paul Wankadia <junyer@google.com>
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
2023-09-07 19:33:15 +00:00
Paul Wankadia
b1e4fdad75 Try plumbing the platform name a different way.
Change-Id: Ic13a6ff61ec445c73483d55241ff42d90f9470b1
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61870
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2023-09-07 17:56:13 +00:00
Paul Wankadia
44277d289e Try using bazelbuild/setup-bazelisk everywhere.
This should hopefully mean that the `bazel`
command found first in the path is actually
Bazelisk.

Revert various previous attempts to get all
this working...

Change-Id: I9a6267aff334de3dc55c7333d83e67ad2ad4ef05
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61610
Reviewed-by: Perry Lorier <perryl@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2023-07-28 13:47:22 +00:00
Paul Wankadia
c20f76ecc5 Tell the Python build where Bazelisk is.
I have no idea what's going on with the
path on GitHub-hosted runners: the `bazelisk`
command works across platforms when called from
`bazel.sh` and also works on macOS when called
from the Python build, but fails on Linux and
Windows when called from the Python build.

Change-Id: I0447cf4a8eef5bd4318d0be7d44c31a357643c19
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61592
Reviewed-by: Perry Lorier <perryl@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2023-07-28 12:41:09 +00:00
Paul Wankadia
8ad66d6df9 Explicitly invoke Bazelisk rather than Bazel.
Change-Id: Ic2fe3c5565bf798173f6f2edae2e4edfffc9a9b5
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61591
Reviewed-by: Perry Lorier <perryl@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2023-07-28 11:19:26 +00:00
Paul Wankadia
4c70d0f310 Prepare to release google-re2 1.1.
Drop support for Python 3.7.
Add support for macOS 13.
Add support for Windows 32-bit.
Use `delvewheel` on Windows.

Fixes #438.

Change-Id: I003e808089abe5bb5dfa77521c1cd9d18f749bfb
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61570
Reviewed-by: Paul Wankadia <junyer@google.com>
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
2023-07-28 09:13:52 +00:00
Paul Wankadia
c53443c80d Tidy up the Python build a little.
Change-Id: I0b152cd0820df0e1e316dbc949e0548043a16600
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61471
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2023-06-30 13:55:41 +00:00
Paul Wankadia
03da4fc085 Use --enable_platform_specific_config in .bazelrc.
This magically applies the `linux`, `macos` or `windows` configuration
depending on the OS. Apart from simplifying things for us, this should
hopefully also unbreak the RE2 build that Bazel folks run in their CI.

Fixes #428.

Change-Id: I2f4192dd728661558a8c4c4c8dd68a720af3ff71
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61370
Reviewed-by: Perry Lorier <perryl@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2023-05-26 10:20:28 +00:00
Paul Wankadia
6dbafa438b Try building the testing for RE2 with CMake again.
Benchmark on Ubuntu seems problematic with LTO, so... disable LTO.

GoogleTest on Windows makes MSVC's linker give "already defined in
testing.lib(exhaustive_tester.obj)" errors, so... frob the testing
library in the faint hope that the issue will finally be resolved.

Change-Id: Ib4237d44a12aa5bd2783d6b1285a5ccb14df4665
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61330
Reviewed-by: Perry Lorier <perryl@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2023-05-19 09:23:50 +00:00
Paul Wankadia
af137a159d Copy over the app/ and python/ subdirectories.
As announced in mid April, RE2 will take a dependency on Abseil in the
`main` branch. This change is one of (quite probably) many that should
ultimately see the `abseil` branch removed.

Change-Id: I0ae5a6643f77d2ebf675443cea7cba558b8c7fef
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61230
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
2023-05-15 18:28:19 +00:00