joncampbell123/dosbox-x
1
0
Fork 0
mirror of https://github.com/joncampbell123/dosbox-x.git synced 2025-05-09 03:41:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not say "Goldplay mode unexpectedly switched off" and act on it, unless it was on in the first place, upon DMA DAC event. This seems to greatly improve the audio in Tyrian 2000, though there is still some popping and crackling because the game likes to repeatedly mask and unmask the DMA channel as it renders audio

Browse Source
This commit is contained in:
Jonathan Campbell 2024-12-15 22:20:46 -08:00
parent d3f4fdc3aa
commit 9213f9106b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/hardware/sblaster.cpp
View File

@ -990,6 +990,7 @@ static void DMA_DAC_Event(Bitu val) {
if (!sb.dma.left)
return;
const bool psingle_sample = sb.single_sample_dma;
/* Fix for 1994 Demoscene entry myth_dw: The demo's Sound Blaster Pro initialization will start DMA with
* count == 1 or 2 (triggering Goldplay mode) but will change the DMA initial counter when it begins
* normal playback. If goldplay stereo hack is enabled and we do not catch this case, the first 0.5 seconds
@ -1000,7 +1001,7 @@ static void DMA_DAC_Event(Bitu val) {
else
sb.single_sample_dma = 0;
if (!sb.single_sample_dma) {
if (psingle_sample && !sb.single_sample_dma) {
// WARNING: This assumes Sound Blaster Pro emulation!
LOG(LOG_SB,LOG_NORMAL)("Goldplay mode unexpectedly switched off, normal DMA playback follows");
sb.dma_dac_mode = 0;