joncampbell123/dosbox-x
1
0
Fork 0
mirror of https://github.com/joncampbell123/dosbox-x.git synced 2025-05-09 03:41:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change magic numbers to readable constants

Browse Source
This commit is contained in:
Jonathan Campbell 2025-05-04 14:21:06 -07:00
parent 66550194cd
commit fc7d762b0a
2 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/iglib.h
View File

@ -22,10 +22,10 @@ extern uint16_t DOSBOXID_VAR dosbox_id_baseio;
# define DOSBOX_IDPORT(x) (dosbox_id_baseio+(x)) # define DOSBOX_IDPORT(x) (dosbox_id_baseio+(x))
#endif #endif
#define DOSBOX_ID_INDEX (0U) #define DOSBOX_ID_INDEX (0U) /* R/W */
#define DOSBOX_ID_DATA (1U) #define DOSBOX_ID_DATA (1U) /* R/W */
#define DOSBOX_ID_STATUS (2U) #define DOSBOX_ID_STATUS (2U) /* R */
#define DOSBOX_ID_COMMAND (2U) #define DOSBOX_ID_COMMAND (2U) /* W */
/* bits 7-6: register select byte index /* bits 7-6: register select byte index
* bits 5-4: register byte index * bits 5-4: register byte index

19
src/ints/bios.cpp
View File

@ -55,6 +55,9 @@ extern bool PS1AudioCard;
#include <sys/stat.h> #include <sys/stat.h>
#include "version_string.h" #include "version_string.h"
#define DOSBOX_INCLUDE
#include "iglib.h"
#if C_LIBPNG #if C_LIBPNG
#include <png.h> #include <png.h>
#endif #endif
@ -1187,17 +1190,17 @@ static void dosbox_integration_port02_command_w(Bitu port,Bitu val,Bitu iolen) {
(void)port; (void)port;
(void)iolen; (void)iolen;
switch (val) { switch (val) {
case 0x00: /* reset latch */ case DOSBOX_ID_CMD_RESET_LATCH:
dosbox_int_register_shf = 0; dosbox_int_register_shf = 0;
dosbox_int_regsel_shf = 0; dosbox_int_regsel_shf = 0;
break; break;
case 0x01: /* flush write */ case DOSBOX_ID_CMD_FLUSH_WRITE:
if (dosbox_int_register_shf != 0) { if (dosbox_int_register_shf != 0) {
dosbox_integration_trigger_write(); dosbox_integration_trigger_write();
dosbox_int_register_shf = 0; dosbox_int_register_shf = 0;
} }
break; break;
case 0x20: /* push state */ case DOSBOX_ID_CMD_PUSH_STATE:
if (dosbox_int_push_save_state()) { if (dosbox_int_push_save_state()) {
dosbox_int_register_shf = 0; dosbox_int_register_shf = 0;
dosbox_int_regsel_shf = 0; dosbox_int_regsel_shf = 0;
@ -1212,7 +1215,7 @@ static void dosbox_integration_port02_command_w(Bitu port,Bitu val,Bitu iolen) {
dosbox_int_error = true; dosbox_int_error = true;
} }
break; break;
case 0x21: /* pop state */ case DOSBOX_ID_CMD_POP_STATE:
if (dosbox_int_pop_save_state()) { if (dosbox_int_pop_save_state()) {
LOG(LOG_MISC,LOG_DEBUG)("DOSBOX-X IG state restored"); LOG(LOG_MISC,LOG_DEBUG)("DOSBOX-X IG state restored");
} }
@ -1221,7 +1224,7 @@ static void dosbox_integration_port02_command_w(Bitu port,Bitu val,Bitu iolen) {
dosbox_int_error = true; dosbox_int_error = true;
} }
break; break;
case 0x22: /* discard state */ case DOSBOX_ID_CMD_DISCARD_STATE:
if (dosbox_int_discard_save_state()) { if (dosbox_int_discard_save_state()) {
LOG(LOG_MISC,LOG_DEBUG)("DOSBOX-X IG state discarded"); LOG(LOG_MISC,LOG_DEBUG)("DOSBOX-X IG state discarded");
} }
@ -1230,13 +1233,13 @@ static void dosbox_integration_port02_command_w(Bitu port,Bitu val,Bitu iolen) {
dosbox_int_error = true; dosbox_int_error = true;
} }
break; break;
case 0x23: /* discard all state */ case DOSBOX_ID_CMD_DISCARD_ALL_STATE:
while (dosbox_int_discard_save_state()); while (dosbox_int_discard_save_state());
break; break;
case 0xFE: /* clear error */ case DOSBOX_ID_CMD_CLEAR_ERROR:
dosbox_int_error = false; dosbox_int_error = false;
break; break;
case 0xFF: /* reset interface */ case DOSBOX_ID_CMD_RESET_INTERFACE:
dosbox_int_busy = false; dosbox_int_busy = false;
dosbox_int_error = false; dosbox_int_error = false;
dosbox_int_regsel = 0xAA55BB66; dosbox_int_regsel = 0xAA55BB66;