This makes them pass shellcheck. Except for a few unused
export warnings.
I also wonder if the majority of these files should be
in the root of the project, or should be moved to "build-scripts"
(or should still even exist).
a few minor changes
one more minor changes
I am working to submit dosbox-x to Fedora for possible inclusion,
but for that I need to ensure I had a suitable spec file. The
one included in the source tree had to be cleaned up.
This is still not 100% the same as the spec file I will use to
submit dosbox-x for a packaging review, but it is close.
One difference is, that this spec file generates a SDL1 binary,
while I will be submitting a SDL2 version upstream for 2 reasons
- SDL2 should be future
- Fedora is unlikely to accept the SDL1 version with customized SDL1
I can change the in-tree spec file to also generate the SDL2 version,
if there is no opposition.
Use reverse DNS naming for .desktop and .metainfo.xml as your
supposed to do nowadays according to freedesktop.org.
This also happens to match what is mandated by flatpak, so it
simplifies the flatpak post install script a little.
+ cleanup the mess that flatpak builds can leave behind when you
do a clean.
I found that the icon used by DOSBox-X comes from
https://www.vogons.org/viewtopic.php?p=79575#p79575
Which apart from Windows and Mac icons also included a SVG icon
which is preferred on Linux, and looks nicer. So add the SVG icon
and update 'make install' and make-rpm.sh to use it.
The SVG icon is placed in contrib/icons
p.s. I found that the tar operation in make-rpm.sh blindly assumes
the directory containing the tree to be named "dosbox-x", instead
of just the current directory, it effectively will tar
../dosbox-x even if your in, say, dosbox-x.clone to keep different
trees apart... I did not change this for now, but it is something
to watch out for.
