llvm/libcxx
1
0
Fork 0
mirror of https://github.com/llvm-mirror/libcxx.git synced 2025-10-24 03:32:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix most GCC test failures.

Browse Source 
This patch fixes almost all currently failing tests when
using GCC ToT.

The specific changes are:

(A) Workaround gcc.gnu.org/PR83921 which rejects variables w/o initializers
in constexpr contexts -- even when the variable is an empty class. This
bug has been worked around at all callsites by adding an initializer.
Additionally a new test, constexpr_init.pass.cpp, has been added to
test that Clang doesn't suffer from these bugs.

(B) Fix streambuf.assign/swap.pass.cpp. This test was never actually
calling the swap method as intended. In fact, the swap function it
intended to call was ill-formed when instantiated. GCC diagnosed
this ill-formedness w/o needing an instantiation.

(C) size_delete11.pass.cpp was fixed by adding c++2a to the list of
unsupported dialects.

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@322810 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eric Fiselier
2018-01-18 03:41:06 +00:00
parent a12e237180
commit 457d2c157b
6 changed files with 61 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/std/algorithms/alg.nonmodifying/alg.find.end/find_end_pred.pass.cpp
View File

@@ -30,14 +30,14 @@ struct count_equal
};
#if TEST_STD_VER > 17
TEST_CONSTEXPR bool test_constexpr() {
constexpr bool test_constexpr() {
int ia[] = {0, 1, 2};
int ib[] = {4, 5, 6};
int ic[] = {0, 1, 2, 3, 4, 5, 0, 1, 2, 3, 4, 0, 1, 2, 3, 0, 1, 2, 0, 1, 0};
typedef forward_iterator<int*> FI;
typedef bidirectional_iterator<int*> BI;
typedef random_access_iterator<int*> RI;
std::equal_to<int> eq;
std::equal_to<int> eq{};
return (std::find_end(FI(std::begin(ic)), FI(std::end(ic)), FI(std::begin(ia)), FI(std::end(ia)), eq) == FI(ic+15))
&& (std::find_end(FI(std::begin(ic)), FI(std::end(ic)), FI(std::begin(ib)), FI(std::end(ib)), eq) == FI(std::end(ic)))
&& (std::find_end(BI(std::begin(ic)), BI(std::end(ic)), BI(std::begin(ia)), BI(std::end(ia)), eq) == BI(ic+15))

5
test/std/algorithms/alg.nonmodifying/alg.find.first.of/find_first_of_pred.pass.cpp
View File

@@ -23,15 +23,14 @@
#include "test_iterators.h"
#if TEST_STD_VER > 17
TEST_CONSTEXPR bool test_constexpr() {
constexpr bool test_constexpr() {
int ia[] = {1, 2, 3};
int ib[] = {7, 8, 9};
int ic[] = {0, 1, 2, 3, 4, 5, 0, 1, 2, 3};
typedef forward_iterator<int*> FI;
typedef bidirectional_iterator<int*> BI;
typedef random_access_iterator<int*> RI;
std::equal_to<int> eq;
std::equal_to<int> eq{};
return (std::find_first_of(FI(std::begin(ic)), FI(std::end(ic)), FI(std::begin(ia)), FI(std::end(ia)), eq) == FI(ic+1))
&& (std::find_first_of(FI(std::begin(ic)), FI(std::end(ic)), FI(std::begin(ib)), FI(std::end(ib)), eq) == FI(std::end(ic)))
&& (std::find_first_of(BI(std::begin(ic)), BI(std::end(ic)), BI(std::begin(ia)), BI(std::end(ia)), eq) == BI(ic+1))

4
test/std/algorithms/alg.nonmodifying/alg.is_permutation/is_permutation_pred.pass.cpp
View File

@@ -29,12 +29,12 @@ bool counting_equals ( const T &a, const T &b ) {
}
#if TEST_STD_VER > 17
TEST_CONSTEXPR bool test_constexpr() {
constexpr bool test_constexpr() {
int ia[] = {0, 0, 0};
int ib[] = {1, 1, 0};
int ic[] = {1, 0, 1};
int id[] = {1};
std::equal_to<int> c;
std::equal_to<int> c{};
return !std::is_permutation(std::begin(ia), std::end(ia), std::begin(ib) , c)
&& !std::is_permutation(std::begin(ia), std::end(ia), std::begin(ib), std::end(ib), c)
&& std::is_permutation(std::begin(ib), std::end(ib), std::begin(ic) , c)