diff --git a/src/experimental/filesystem/operations.cpp b/src/experimental/filesystem/operations.cpp index 0420e12e3..5d0a9a9dd 100644 --- a/src/experimental/filesystem/operations.cpp +++ b/src/experimental/filesystem/operations.cpp @@ -236,12 +236,8 @@ void __copy(const path& from, const path& to, copy_options options, } return; } - else if (is_directory(f)) { - if (not bool(copy_options::recursive & options) && - bool(copy_options::__in_recursive_copy & options)) - { - return; - } + else if (is_directory(f) && (bool(copy_options::recursive & options) || + copy_options::none == options)) { if (!exists(t)) { // create directory to with attributes from 'from'. diff --git a/test/std/experimental/filesystem/fs.op.funcs/fs.op.copy/copy.pass.cpp b/test/std/experimental/filesystem/fs.op.funcs/fs.op.copy/copy.pass.cpp index 7d318719f..61d963a51 100644 --- a/test/std/experimental/filesystem/fs.op.funcs/fs.op.copy/copy.pass.cpp +++ b/test/std/experimental/filesystem/fs.op.funcs/fs.op.copy/copy.pass.cpp @@ -69,37 +69,44 @@ TEST_CASE(test_error_reporting) const path fifo = env.create_fifo("fifo"); TEST_REQUIRE(is_other(fifo)); + const auto test_ec = GetTestEC(); + // !exists(f) { - std::error_code ec; + std::error_code ec = test_ec; const path f = StaticEnv::DNE; const path t = env.test_root; fs::copy(f, t, ec); TEST_REQUIRE(ec); + TEST_REQUIRE(ec != test_ec); TEST_CHECK(checkThrow(f, t, ec)); } { // equivalent(f, t) == true - std::error_code ec; + std::error_code ec = test_ec; fs::copy(file, file, ec); TEST_REQUIRE(ec); + TEST_REQUIRE(ec != test_ec); TEST_CHECK(checkThrow(file, file, ec)); } { // is_directory(from) && is_file(to) - std::error_code ec; + std::error_code ec = test_ec; fs::copy(dir, file, ec); TEST_REQUIRE(ec); + TEST_REQUIRE(ec != test_ec); TEST_CHECK(checkThrow(dir, file, ec)); } { // is_other(from) - std::error_code ec; + std::error_code ec = test_ec; fs::copy(fifo, dir, ec); TEST_REQUIRE(ec); + TEST_REQUIRE(ec != test_ec); TEST_CHECK(checkThrow(fifo, dir, ec)); } { // is_other(to) - std::error_code ec; + std::error_code ec = test_ec; fs::copy(file, fifo, ec); TEST_REQUIRE(ec); + TEST_REQUIRE(ec != test_ec); TEST_CHECK(checkThrow(file, fifo, ec)); } } @@ -129,11 +136,13 @@ TEST_CASE(from_is_symlink) std::error_code ec = GetTestEC(); fs::copy(symlink, file, copy_options::copy_symlinks, ec); TEST_CHECK(ec); + TEST_CHECK(ec != GetTestEC()); } { // create symlinks but target exists std::error_code ec = GetTestEC(); fs::copy(symlink, file, copy_options::create_symlinks, ec); TEST_CHECK(ec); + TEST_CHECK(ec != GetTestEC()); } } @@ -246,6 +255,19 @@ TEST_CASE(from_is_directory) TEST_CHECK(file_size(nested_created) == FI.size); } } - } + +TEST_CASE(test_otherwise_no_effects_clause) +{ + scoped_test_env env; + const path dir = env.create_dir("dir1"); + { // skip copy because of directory + const path dest = env.make_env_path("dest1"); + std::error_code ec; + fs::copy(dir, dest, CO::directories_only, ec); + TEST_CHECK(!ec); + TEST_CHECK(!exists(dest)); + } +} + TEST_SUITE_END() diff --git a/www/cxx1z_status.html b/www/cxx1z_status.html index 925d6a606..95c9d88c7 100644 --- a/www/cxx1z_status.html +++ b/www/cxx1z_status.html @@ -286,7 +286,7 @@ 2671Errors in CopyOuluComplete 2673status() effects cannot be implemented as specifiedOuluComplete 2674Bidirectional iterator requirement on path::iterator is very expensiveOuluComplete - 2683filesystem::copy() says "no effects"Oulu + 2683filesystem::copy() says "no effects"OuluComplete 2684priority_queue lacking comparator typedefOuluComplete 2685shared_ptr deleters must not throw on move constructionOuluComplete 2687{inclusive,exclusive}_scan misspecifiedOulu