From 50fe47bc8b8970c75dff2c84381e026acb7910a7 Mon Sep 17 00:00:00 2001 From: "Stephan T. Lavavej" Date: Wed, 23 Nov 2016 22:02:53 +0000 Subject: [PATCH] [libcxx] [test] D27020: Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 7/12. When initializing unsigned integers to their maximum values, change "const T M(~0);" to "const T M(static_cast(-1));". ~0 and -1 are equivalent, but I consider the -1 form to be significantly clearer (and more consistent with other tests). git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@287827 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp | 2 +- test/std/numerics/rand/rand.eng/rand.eng.lcong/copy.pass.cpp | 2 +- test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp | 2 +- test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp b/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp index 8c09f4fd0..d96ccf9de 100644 --- a/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp +++ b/test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp @@ -37,7 +37,7 @@ test() test1(); test1(); test1(); - const T M(~0); + const T M(static_cast(-1)); test1(); test1(); test1(); diff --git a/test/std/numerics/rand/rand.eng/rand.eng.lcong/copy.pass.cpp b/test/std/numerics/rand/rand.eng/rand.eng.lcong/copy.pass.cpp index 4b2b20da1..b38e8f583 100644 --- a/test/std/numerics/rand/rand.eng/rand.eng.lcong/copy.pass.cpp +++ b/test/std/numerics/rand/rand.eng/rand.eng.lcong/copy.pass.cpp @@ -37,7 +37,7 @@ test() test1(); test1(); test1(); - const T M(~0); + const T M(static_cast(-1)); test1(); test1(); test1(); diff --git a/test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp b/test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp index 6c4a7f434..734b42099 100644 --- a/test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp +++ b/test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp @@ -36,7 +36,7 @@ test() test1(); test1(); test1(); - const T M(~0); + const T M(static_cast(-1)); test1(); test1(); test1(); diff --git a/test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp b/test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp index 7ff4480ba..cd496fdbc 100644 --- a/test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp +++ b/test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp @@ -72,7 +72,7 @@ test() test1(); test1(); test1(); - const T M(~0); + const T M(static_cast(-1)); test1(); test1(); test1();