From 713f4db2e5b37ef84c5506fa1b65f3b76798d594 Mon Sep 17 00:00:00 2001 From: Howard Hinnant Date: Sat, 31 Aug 2013 16:51:56 +0000 Subject: [PATCH] SFINAE out duration converting constructor if the constructor would otherwise cause a ratio compile-time overflow. This fixes LWG 2094. git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@189722 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/chrono | 36 +++++++++++++++++-- .../time.point.cast/time_point_cast.pass.cpp | 4 +++ www/cxx1y_status.html | 2 +- 3 files changed, 39 insertions(+), 3 deletions(-) diff --git a/include/chrono b/include/chrono index 9fb774317..afc518170 100644 --- a/include/chrono +++ b/include/chrono @@ -409,6 +409,37 @@ class _LIBCPP_TYPE_VIS_ONLY duration static_assert(!__is_duration<_Rep>::value, "A duration representation can not be a duration"); static_assert(__is_ratio<_Period>::value, "Second template parameter of duration must be a std::ratio"); static_assert(_Period::num > 0, "duration period must be positive"); + + template + struct __no_overflow + { + private: + static const intmax_t __gcd_n1_n2 = __static_gcd<_R1::num, _R2::num>::value; + static const intmax_t __gcd_d1_d2 = __static_gcd<_R1::den, _R2::den>::value; + static const intmax_t __n1 = _R1::num / __gcd_n1_n2; + static const intmax_t __d1 = _R1::den / __gcd_d1_d2; + static const intmax_t __n2 = _R2::num / __gcd_n1_n2; + static const intmax_t __d2 = _R2::den / __gcd_d1_d2; + static const intmax_t max = -((intmax_t(1) << (sizeof(intmax_t) * CHAR_BIT - 1)) + 1); + + template + struct __mul // __overflow == false + { + static const intmax_t value = _Xp * _Yp; + }; + + template + struct __mul<_Xp, _Yp, true> + { + static const intmax_t value = 1; + }; + + public: + static const bool value = (__n1 <= max / __d2) && (__n2 <= max / __d1); + typedef ratio<__mul<__n1, __d2, !value>::value, + __mul<__n2, __d1, !value>::value> type; + }; + public: typedef _Rep rep; typedef _Period period; @@ -440,9 +471,10 @@ public: duration(const duration<_Rep2, _Period2>& __d, typename enable_if < + __no_overflow<_Period2, period>::value && ( treat_as_floating_point::value || - (ratio_divide<_Period2, period>::type::den == 1 && - !treat_as_floating_point<_Rep2>::value) + (__no_overflow<_Period2, period>::type::den == 1 && + !treat_as_floating_point<_Rep2>::value)) >::type* = 0) : __rep_(_VSTD::chrono::duration_cast(__d).count()) {} diff --git a/test/utilities/time/time.point/time.point.cast/time_point_cast.pass.cpp b/test/utilities/time/time.point/time.point.cast/time_point_cast.pass.cpp index 04b43672c..7d7e82ac5 100644 --- a/test/utilities/time/time.point/time.point.cast/time_point_cast.pass.cpp +++ b/test/utilities/time/time.point/time.point.cast/time_point_cast.pass.cpp @@ -35,6 +35,8 @@ test(const FromDuration& df, const ToDuration& d) } } +#if _LIBCPP_STD_VER > 11 + template void test_constexpr () { @@ -49,6 +51,8 @@ void test_constexpr () } +#endif + int main() { test(std::chrono::milliseconds(7265000), std::chrono::hours(2)); diff --git a/www/cxx1y_status.html b/www/cxx1y_status.html index c1f61094d..da920a5b7 100644 --- a/www/cxx1y_status.html +++ b/www/cxx1y_status.html @@ -140,7 +140,7 @@ 2091Misplaced effect in m.try_lock_for()BristolComplete 2092Vague Wording for condition_variable_anyBristolComplete 2093Throws clause of condition_variable::wait with predicateBristolComplete - 2094duration conversion overflow shouldn't participate in overload resolutionBristol + 2094duration conversion overflow shouldn't participate in overload resolutionBristolComplete 2122merge() stability for lists versus forward listsBristol 2128Absence of global functions cbegin/cendBristolComplete 2145error_category default constructorBristolComplete