libcxx

mirror of https://github.com/llvm-mirror/libcxx.git synced 2025-10-24 03:32:35 +08:00

Files

Eric Fiselier 1bc7a4b31e [libc++] Fix PR32979 - types with a private std::enable_shared_from_this base break shared_ptr

Summary:
This patch fixes bugs.llvm.org/PR32979.

[util.smartptr.shared.const] says:
> In the constructor definitions below, enables shared_from_this with p, for a pointer p of type Y*, means
> that if Y has an unambiguous and accessible base class that is a specialization of enable_shared_from_-
> this.

This means that libc++ needs to respect the access specifier of the base class, and not attempt to construct
and enabled_shared_from_this base if it is private. However access specifiers don't affect overload resolution
so our current implementation will attempt to construct the private base. 

This patch uses SFINAE to correctly detect if the shared_ptr input has an accessible enable_shared_from_this
base class.

Reviewers: mclow.lists

Reviewed By: mclow.lists

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D33033

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@302709 91177308-0d34-0410-b5e6-96231b3b80d8

2017-05-10 19:35:49 +00:00

allocator.tag

Move test into test/std subdirectory.

2014-12-20 01:40:03 +00:00

allocator.traits

[libc++] Remove various C++03 feature test macros

2016-09-25 03:34:28 +00:00

allocator.uses

Fix failure on 03 bot

2016-09-22 03:25:22 +00:00

c.malloc

Move test into test/std subdirectory.