Files
libcxx/test/std/thread/thread.condition/thread.condition.condvarany/wait_terminates.sh.cpp
JF Bastien e15dd4e32e Support tests in freestanding
Summary:
Freestanding is *weird*. The standard allows it to differ in a bunch of odd
manners from regular C++, and the committee would like to improve that
situation. I'd like to make libc++ behave better with what freestanding should
be, so that it can be a tool we use in improving the standard. To do that we
need to try stuff out, both with "freestanding the language mode" and
"freestanding the library subset".

Let's start with the super basic: run the libc++ tests in freestanding, using
clang as the compiler, and see what works. The easiest hack to do this:

In utils/libcxx/test/config.py add:

  self.cxx.compile_flags += ['-ffreestanding']

Run the tests and they all fail.

Why? Because in freestanding `main` isn't special. This "not special" property
has two effects: main doesn't get mangled, and main isn't allowed to omit its
`return` statement. The first means main gets mangled and the linker can't
create a valid executable for us to test. The second means we spew out warnings
(ew) and the compiler doesn't insert the `return` we omitted, and main just
falls of the end and does whatever undefined behavior (if you're luck, ud2
leading to non-zero return code).

Let's start my work with the basics. This patch changes all libc++ tests to
declare `main` as `int main(int, char**` so it mangles consistently (enabling us
to declare another `extern "C"` main for freestanding which calls the mangled
one), and adds `return 0;` to all places where it was missing. This touches 6124
files, and I apologize.

The former was done with The Magic Of Sed.

The later was done with a (not quite correct but decent) clang tool:

  https://gist.github.com/jfbastien/793819ff360baa845483dde81170feed

This works for most tests, though I did have to adjust a few places when e.g.
the test runs with `-x c`, macros are used for main (such as for the filesystem
tests), etc.

Once this is in we can create a freestanding bot which will prevent further
regressions. After that, we can start the real work of supporting C++
freestanding fairly well in libc++.

<rdar://problem/47754795>

Reviewers: ldionne, mclow.lists, EricWF

Subscribers: christof, jkorous, dexonsmith, arphaman, miyuki, libcxx-commits

Differential Revision: https://reviews.llvm.org/D57624

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@353086 91177308-0d34-0410-b5e6-96231b3b80d8
2019-02-04 20:31:13 +00:00

136 lines
3.8 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: libcpp-no-exceptions
// UNSUPPORTED: libcpp-has-no-threads
// <condition_variable>
// class condition_variable_any;
// RUN: %build
// RUN: %run 1
// RUN: %run 2
// RUN: %run 3
// RUN: %run 4
// RUN: %run 5
// RUN: %run 6
// -----------------------------------------------------------------------------
// Overview
// Check that std::terminate is called if wait(...) fails to meet its post
// conditions. This can happen when reacquiring the mutex throws
// an exception.
//
// The following methods are tested within this file
// 1. void wait(Lock& lock);
// 2. void wait(Lock& lock, Pred);
// 3. void wait_for(Lock& lock, Duration);
// 4. void wait_for(Lock& lock, Duration, Pred);
// 5. void wait_until(Lock& lock, TimePoint);
// 6. void wait_until(Lock& lock, TimePoint, Pred);
//
// Plan
// 1 Create a mutex type, 'ThrowingMutex', that throws when the lock is acquired
// for the *second* time.
//
// 2 Replace the terminate handler with one that exits with a '0' exit code.
//
// 3 Create a 'condition_variable_any' object 'cv' and a 'ThrowingMutex'
// object 'm' and lock 'm'.
//
// 4 Start a thread 'T2' that will notify 'cv' once 'm' has been unlocked.
//
// 5 From the main thread call the specified wait method on 'cv' with 'm'.
// When 'T2' notifies 'cv' and the wait method attempts to re-lock
// 'm' an exception will be thrown from 'm.lock()'.
//
// 6 Check that control flow does not return from the wait method and that
// terminate is called (If the program exits with a 0 exit code we know
// that terminate has been called)
#include <condition_variable>
#include <atomic>
#include <thread>
#include <chrono>
#include <string>
#include <cstdlib>
#include <cassert>
void my_terminate() {
std::_Exit(0); // Use _Exit to prevent cleanup from taking place.
}
// The predicate used in the cv.wait calls.
bool pred = false;
bool pred_function() {
return pred == true;
}
class ThrowingMutex
{
std::atomic_bool locked;
unsigned state = 0;
ThrowingMutex(const ThrowingMutex&) = delete;
ThrowingMutex& operator=(const ThrowingMutex&) = delete;
public:
ThrowingMutex() {
locked = false;
}
~ThrowingMutex() = default;
void lock() {
locked = true;
if (++state == 2) {
assert(pred); // Check that we actually waited until we were signaled.
throw 1; // this throw should end up calling terminate()
}
}
void unlock() { locked = false; }
bool isLocked() const { return locked == true; }
};
ThrowingMutex mut;
std::condition_variable_any cv;
void signal_me() {
while (mut.isLocked()) {} // wait until T1 releases mut inside the cv.wait call.
pred = true;
cv.notify_one();
}
typedef std::chrono::system_clock Clock;
typedef std::chrono::milliseconds MS;
int main(int argc, char **argv) {
assert(argc == 2);
int id = std::stoi(argv[1]);
assert(id >= 1 && id <= 6);
std::set_terminate(my_terminate); // set terminate after std::stoi because it can throw.
MS wait(250);
try {
mut.lock();
assert(pred == false);
std::thread(signal_me).detach();
switch (id) {
case 1: cv.wait(mut); break;
case 2: cv.wait(mut, pred_function); break;
case 3: cv.wait_for(mut, wait); break;
case 4: cv.wait_for(mut, wait, pred_function); break;
case 5: cv.wait_until(mut, Clock::now() + wait); break;
case 6: cv.wait_until(mut, Clock::now() + wait, pred_function); break;
default: assert(false);
}
} catch (...) {}
assert(false);
return 0;
}