mirror of
https://github.com/llvm-mirror/libcxx.git
synced 2025-10-23 01:18:52 +08:00
ea714e73a6
The expected 'filesystem::path::compare' result states that for different
path only result sign contains the information about passed arguments
(not its integer value). This is due it uses the output of other compare
functions (basic_string_view and char_traits) without further handling and
char_traits uses memcmp for final buffer comparison.
However for GLIBC on AArch64 the code:
int ret = memcmp ("b/a/c", "a/b/c", 1);
Results in '64' where for x86_64 it results in '1'.
This patch fixes the expected 'filesystem::path::compare' by normalizing
all the results before assert comparison.
git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@278745 91177308-0d34-0410-b5e6-96231b3b80d8
133 lines
4.2 KiB
C++
133 lines
4.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is dual licensed under the MIT and the University of Illinois Open
|
|
// Source Licenses. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// UNSUPPORTED: c++98, c++03
|
|
|
|
// <experimental/filesystem>
|
|
|
|
// class path
|
|
|
|
// int compare(path const&) const noexcept;
|
|
// int compare(string_type const&) const;
|
|
// int compare(value_type const*) const;
|
|
//
|
|
// bool operator==(path const&, path const&) noexcept;
|
|
// bool operator!=(path const&, path const&) noexcept;
|
|
// bool operator< (path const&, path const&) noexcept;
|
|
// bool operator<=(path const&, path const&) noexcept;
|
|
// bool operator> (path const&, path const&) noexcept;
|
|
// bool operator>=(path const&, path const&) noexcept;
|
|
//
|
|
// size_t hash_value(path const&) noexcept;
|
|
|
|
#include <experimental/filesystem>
|
|
#include <type_traits>
|
|
#include <vector>
|
|
#include <cassert>
|
|
|
|
#include "test_macros.h"
|
|
#include "test_iterators.h"
|
|
#include "count_new.hpp"
|
|
#include "filesystem_test_helper.hpp"
|
|
|
|
namespace fs = std::experimental::filesystem;
|
|
|
|
struct PathCompareTest {
|
|
const char* LHS;
|
|
const char* RHS;
|
|
int expect;
|
|
};
|
|
|
|
#define LONGA "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
|
|
#define LONGB "BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB"
|
|
#define LONGC "CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC"
|
|
#define LONGD "DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD"
|
|
const PathCompareTest CompareTestCases[] =
|
|
{
|
|
{"", "", 0},
|
|
{"a", "", 1},
|
|
{"", "a", -1},
|
|
{"a/b/c", "a/b/c", 0},
|
|
{"b/a/c", "a/b/c", 1},
|
|
{"a/b/c", "b/a/c", -1},
|
|
{"a/b", "a/b/c", -1},
|
|
{"a/b/c", "a/b", 1},
|
|
{"a/b/", "a/b/.", 0},
|
|
{"a/b//////", "a/b/////.", 0},
|
|
{"a/.././b", "a///..//.////b", 0},
|
|
{"//foo//bar///baz////", "//foo/bar/baz/", 0}, // duplicate separators
|
|
{"///foo/bar", "/foo/bar", 0}, // "///" is not a root directory
|
|
{"/foo/bar/", "/foo/bar", 1}, // trailing separator
|
|
{"//" LONGA "////" LONGB "/" LONGC "///" LONGD, "//" LONGA "/" LONGB "/" LONGC "/" LONGD, 0},
|
|
{ LONGA "/" LONGB "/" LONGC, LONGA "/" LONGB "/" LONGB, 1}
|
|
|
|
};
|
|
#undef LONGA
|
|
#undef LONGB
|
|
#undef LONGC
|
|
#undef LONGD
|
|
|
|
static inline int normalize_ret(int ret)
|
|
{
|
|
return ret < 0 ? -1 : (ret > 0 ? 1 : 0);
|
|
}
|
|
|
|
int main()
|
|
{
|
|
using namespace fs;
|
|
for (auto const & TC : CompareTestCases) {
|
|
const path p1(TC.LHS);
|
|
const path p2(TC.RHS);
|
|
const std::string R(TC.RHS);
|
|
const std::string_view RV(TC.RHS);
|
|
const int E = TC.expect;
|
|
{ // compare(...) functions
|
|
DisableAllocationGuard g; // none of these operations should allocate
|
|
|
|
// check runtime results
|
|
int ret1 = normalize_ret(p1.compare(p2));
|
|
int ret2 = normalize_ret(p1.compare(R));
|
|
int ret3 = normalize_ret(p1.compare(TC.RHS));
|
|
int ret4 = normalize_ret(p1.compare(RV));
|
|
assert(ret1 == ret2 && ret1 == ret3 && ret1 == ret4);
|
|
assert(ret1 == E);
|
|
|
|
// check signatures
|
|
ASSERT_NOEXCEPT(p1.compare(p2));
|
|
}
|
|
{ // comparison operators
|
|
DisableAllocationGuard g; // none of these operations should allocate
|
|
|
|
// Check runtime result
|
|
assert((p1 == p2) == (E == 0));
|
|
assert((p1 != p2) == (E != 0));
|
|
assert((p1 < p2) == (E < 0));
|
|
assert((p1 <= p2) == (E <= 0));
|
|
assert((p1 > p2) == (E > 0));
|
|
assert((p1 >= p2) == (E >= 0));
|
|
|
|
// Check signatures
|
|
ASSERT_NOEXCEPT(p1 == p2);
|
|
ASSERT_NOEXCEPT(p1 != p2);
|
|
ASSERT_NOEXCEPT(p1 < p2);
|
|
ASSERT_NOEXCEPT(p1 <= p2);
|
|
ASSERT_NOEXCEPT(p1 > p2);
|
|
ASSERT_NOEXCEPT(p1 >= p2);
|
|
}
|
|
{ // check hash values
|
|
auto h1 = hash_value(p1);
|
|
auto h2 = hash_value(p2);
|
|
assert((h1 == h2) == (p1 == p2));
|
|
// check signature
|
|
ASSERT_SAME_TYPE(size_t, decltype(hash_value(p1)));
|
|
ASSERT_NOEXCEPT(hash_value(p1));
|
|
}
|
|
}
|
|
}
|