Kitware/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-10-14 02:08:27 +08:00
Code Issues Projects Releases Wiki Activity

cmake: --build -j <jobs> should not accept 0.

Browse Source 
Fixes #19059
This commit is contained in:
Fred Baksik
2019-04-22 11:01:24 -04:00
parent 955f7f41c0
commit 6ad699358b
11 changed files with 48 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Help/manual/cmake.1.rst
View File

@@ -280,6 +280,9 @@ following options:
The :envvar:`CMAKE_BUILD_PARALLEL_LEVEL` environment variable, if set,
specifies a default parallel level when this option is not given.
Some native build tools always build in parallel. The use of ``<jobs>``
value of ``1`` can be used to limit to a single job.
``--target <tgt>..., -t <tgt>...``
Build ``<tgt>`` instead of default targets. May be specified multiple times.

24
Source/cmakemain.cxx
View File

@@ -24,6 +24,7 @@
#endif
#include <cassert>
#include <climits>
#include <ctype.h>
#include <iostream>
#include <string.h>
@@ -69,7 +70,7 @@ static const char* cmDocumentationUsageNote[][2] = {
" --config <cfg> = For multi-configuration tools, choose <cfg>.\n" \
" --clean-first = Build target 'clean' first, then build.\n" \
" (To clean only, use --target 'clean'.)\n" \
" --verbose, -v = Enable verbose output - if supported - including\n" \
" --verbose, -v = Enable verbose output - if supported - including\n" \
" the build commands to be executed. \n" \
" -- = Pass remaining options to the native tool.\n"
@@ -393,7 +394,14 @@ int extract_job_number(int& index, char const* current, char const* next,
if (jobString.empty()) {
jobs = cmake::DEFAULT_BUILD_PARALLEL_LEVEL;
} else if (cmSystemTools::StringToULong(jobString.c_str(), &numJobs)) {
jobs = int(numJobs);
if (numJobs == 0) {
std::cerr
<< "The <jobs> value requires a positive integer argument.\n\n";
} else if (numJobs > INT_MAX) {
std::cerr << "The <jobs> value is too large.\n\n";
} else {
jobs = int(numJobs);
}
} else {
std::cerr << "'" << command.substr(0, len_of_flag) << "' invalid number '"
<< jobString << "' given.\n\n";
@@ -505,7 +513,17 @@ static int do_build(int ac, char const* const* av)
} else {
unsigned long numJobs = 0;
if (cmSystemTools::StringToULong(parallel.c_str(), &numJobs)) {
jobs = int(numJobs);
if (numJobs == 0) {
std::cerr << "The CMAKE_BUILD_PARALLEL_LEVEL environment variable "
"requires a positive integer argument.\n\n";
dir.clear();
} else if (numJobs > INT_MAX) {
std::cerr << "The CMAKE_BUILD_PARALLEL_LEVEL environment variable "
"is too large.\n\n";
dir.clear();
} else {
jobs = int(numJobs);
}
} else {
std::cerr << "'CMAKE_BUILD_PARALLEL_LEVEL' environment variable\n"
<< "invalid number '" << parallel << "' given.\n\n";

1
Tests/RunCMake/CommandLine/BuildDir--build--parallel-large-result.txt Normal file
View File

@@ -0,0 +1 @@
1

3
Tests/RunCMake/CommandLine/BuildDir--build--parallel-large-stderr.txt Normal file
View File

@@ -0,0 +1,3 @@
^The <jobs> value is too large\.
+
Usage: cmake --build <dir> \[options\] \[-- \[native-options\]\]

1
Tests/RunCMake/CommandLine/BuildDir--build--parallel-zero-result.txt Normal file
View File

@@ -0,0 +1 @@
1

3
Tests/RunCMake/CommandLine/BuildDir--build--parallel-zero-stderr.txt Normal file
View File

@@ -0,0 +1,3 @@
^The <jobs> value requires a positive integer argument\.
+
Usage: cmake --build <dir> \[options\] \[-- \[native-options\]\]

1
Tests/RunCMake/CommandLine/BuildDir--build-jobs-large-result.txt Normal file
View File

@@ -0,0 +1 @@
1

3
Tests/RunCMake/CommandLine/BuildDir--build-jobs-large-stderr.txt Normal file
View File

@@ -0,0 +1,3 @@
^The <jobs> value is too large\.
+
Usage: cmake --build <dir> \[options\] \[-- \[native-options\]\]

1
Tests/RunCMake/CommandLine/BuildDir--build-jobs-zero-result.txt Normal file
View File

@@ -0,0 +1 @@
1

3
Tests/RunCMake/CommandLine/BuildDir--build-jobs-zero-stderr.txt Normal file
View File

@@ -0,0 +1,3 @@
^The <jobs> value requires a positive integer argument\.
+
Usage: cmake --build <dir> \[options\] \[-- \[native-options\]\]

8
Tests/RunCMake/CommandLine/RunCMakeTest.cmake
View File

@@ -149,6 +149,14 @@ function(run_BuildDir)
${CMAKE_COMMAND} --build BuildDir-build --parallel2)
run_cmake_command(BuildDir--build--parallel-no-space-good-number-trailing--target ${CMAKE_COMMAND} -E chdir ..
${CMAKE_COMMAND} --build BuildDir-build --parallel2 --target CustomTarget)
run_cmake_command(BuildDir--build-jobs-zero ${CMAKE_COMMAND} -E chdir ..
${CMAKE_COMMAND} --build BuildDir-build -j 0)
run_cmake_command(BuildDir--build--parallel-zero ${CMAKE_COMMAND} -E chdir ..
${CMAKE_COMMAND} --build BuildDir-build --parallel 0)
run_cmake_command(BuildDir--build-jobs-large ${CMAKE_COMMAND} -E chdir ..
${CMAKE_COMMAND} --build BuildDir-build -j 4294967293)
run_cmake_command(BuildDir--build--parallel-large ${CMAKE_COMMAND} -E chdir ..
${CMAKE_COMMAND} --build BuildDir-build --parallel 4294967293)
# No default jobs for Xcode and FreeBSD build command
if(NOT RunCMake_GENERATOR MATCHES "Xcode" AND NOT CMAKE_SYSTEM_NAME MATCHES "FreeBSD")