apache/nuttx-apps
1
0
Fork 0
mirror of https://github.com/apache/nuttx-apps.git synced 2025-10-17 07:12:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

examples/usbserial: Fix style issues in host.c

Browse Source 
- Break long preprocessor conditionals across multiple lines
- Add spaces around operators for better readability
- Reformat long string literals to fit within line length limits
- Improve consistency in spacing around parentheses and brackets

Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
This commit is contained in:
Huang Qi
2025-01-10 23:36:47 +08:00
committed by Xiang Xiao
parent f7e7453807
commit 46f77a632d
1 changed files with 70 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

130
examples/usbserial/host.c
View File

@@ -38,14 +38,17 @@
* Pre-processor Definitions * Pre-processor Definitions
****************************************************************************/ ****************************************************************************/
#if defined(CONFIG_EXAMPLES_USBSERIAL_INONLY) && defined(CONFIG_EXAMPLES_USBSERIAL_OUTONLY) #if defined(CONFIG_EXAMPLES_USBSERIAL_INONLY) && \
defined(CONFIG_EXAMPLES_USBSERIAL_OUTONLY)
# error "Cannot define both CONFIG_EXAMPLES_USBSERIAL_INONLY and _OUTONLY" # error "Cannot define both CONFIG_EXAMPLES_USBSERIAL_INONLY and _OUTONLY"
#endif #endif
#if defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) && defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) #if defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) && \
defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG)
# error "Cannot define both CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL and _ONLYBIG" # error "Cannot define both CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL and _ONLYBIG"
#endif #endif
#if !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) && !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) #if !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) && \
!defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL)
# ifndef CONFIG_EXAMPLES_USBSERIAL_INONLY # ifndef CONFIG_EXAMPLES_USBSERIAL_INONLY
# define COUNTER_NEEDED 1 # define COUNTER_NEEDED 1
# endif # endif
@@ -70,56 +73,60 @@ static const char g_shortmsg[] = "Sure... You betcha!!\n";
#ifndef CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL #ifndef CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL
static const char g_longmsg[] = static const char g_longmsg[] =
"I am proud to come to this city as the guest of your distinguished Mayor, " "I am proud to come to this city as the guest of your distinguished "
"who has symbolized throughout the world the fighting spirit of West Berlin. " "Mayor, who has symbolized throughout the world the fighting spirit of "
"And I am proud to visit the Federal Republic with your distinguished Chancellor " "West Berlin. And I am proud to visit the Federal Republic with your "
"who for so many years has committed Germany to democracy and freedom and " "distinguished Chancellor who for so many years has committed Germany "
"progress, and to come here in the company of my fellow American, General Clay, " "to democracy and freedom and progress, and to come here in the company "
"who has been in this city during its great moments of crisis and will come " "of my fellow American, General Clay, who has been in this city during "
"again if ever needed.\n" "its great moments of crisis and will come again if ever needed.\n"
"Two thousand years ago the proudest boast was \"civis Romanus sum.\" Today, " "Two thousand years ago the proudest boast was \"civis Romanus sum.\" "
"in the world of freedom, the proudest boast is \"Ich bin ein Berliner.\"\r\"" "Today, in the world of freedom, the proudest boast is "
"I appreciate my interpreter translating my German!\n" "\"Ich bin ein Berliner.\"\r\"I appreciate my interpreter translating "
"There are many people in the world who really don't understand, or say they " "my German!\nThere are many people in the world who really "
"don't, what is the great issue between the free world and the Communist world. " "don't understand, or say they don't, what is the great issue between "
"Let them come to Berlin. There are some who say that communism is the wave of " "the free world and the Communist world. Let them come to Berlin. "
"the future. Let them come to Berlin. And there are some who say in Europe and " "There are some who say that communism is the wave of the future. "
"elsewhere we can work with the Communists. Let them come to Berlin. And there " "Let them come to Berlin. And there are some who say in Europe and "
"are even a few who say that it is true that communism is an evil system, but it " "elsewhere we can work with the Communists. Let them come to Berlin. "
"permits us to make economic progress. Lass' sie nach Berlin kommen. Let them " "And there are even a few who say that it is true that communism is "
"come to Berlin.\n" "an evil system, but it permits us to make economic progress. "
"Freedom has many difficulties and democracy is not perfect, but we have never " "Lass' sie nach Berlin kommen. Let them come to Berlin.\n"
"had to put a wall up to keep our people in, to prevent them from leaving us. I " "Freedom has many difficulties and democracy is not perfect, but we have "
"want to say, on behalf of my countrymen, who live many miles away on the other " "never had to put a wall up to keep our people in, to prevent them from "
"side of the Atlantic, who are far distant from you, that they take the greatest " "leaving us. I want to say, on behalf of my countrymen, who live many "
"pride that they have been able to share with you, even from a distance, the " "miles away on the other side of the Atlantic, who are far distant "
"story of the last 18 years. I know of no town, no city, that has been besieged " "from you, that they take the greatest pride that they have been able "
"for 18 years that still lives with the vitality and the force, and the hope and " "to share with you, even from a distance, the story of the last 18 years. "
"the determination of the city of West Berlin. While the wall is the most obvious " "I know of no town, no city, that has been besieged for 18 years that "
"and vivid demonstration of the failures of the Communist system, for all the " "still lives with the vitality and the force, and the hope and the "
"world to see, we take no satisfaction in it, for it is, as your Mayor has said, " "determination of the city of West Berlin. While the wall is the most "
"an offense not only against history but an offense against humanity, separating " "obvious and vivid demonstration of the failures of the Communist system, "
"families, dividing husbands and wives and brothers and sisters, and dividing a " "for all the world to see, we take no satisfaction in it, for it is, "
"people who wish to be joined together.\n" "as your Mayor has said, an offense not only against history but an "
"What is true of this city is true of Germany--real, lasting peace in Europe can " "offense against humanity, separating families, dividing husbands and "
"never be assured as long as one German out of four is denied the elementary " "wives and brothers and sisters, and dividing a people who wish to be "
"right of free men, and that is to make a free choice. In 18 years of peace and " "joined together.\nWhat is true of this city is true of Germany--real, "
"good faith, this generation of Germans has earned the right to be free, " "lasting peace in Europe can never be assured as long as one German "
"including the right to unite their families and their nation in lasting peace, " "out of four is denied the elementary right of free men, and that is "
"with good will to all people. You live in a defended island of freedom, but " "to make a free choice. In 18 years of peace and good faith, this "
"your life is part of the main. So let me ask you as I close, to lift your eyes " "generation of Germans has earned the right to be free, including the "
"beyond the dangers of today, to the hopes of tomorrow, beyond the freedom merely " "right to unite their families and their nation in lasting peace, "
"of this city of Berlin, or your country of Germany, to the advance of freedom " "with good will to all people. You live in a defended island of freedom, "
"everywhere, beyond the wall to the day of peace with justice, beyond yourselves " "but your life is part of the main. So let me ask you as I close, to lift "
"and ourselves to all mankind.\n" "your eyes beyond the dangers of today, to the hopes of tomorrow, beyond "
"Freedom is indivisible, and when one man is enslaved, all are not free. When all " "the freedom merely of this city of Berlin, or your country of Germany, "
"are free, then we can look forward to that day when this city will be joined as " "to the advance of freedom everywhere, beyond the wall to the day of "
"one and this country and this great Continent of Europe in a peaceful and hopeful " "peace with justice, beyond yourselves and ourselves to all mankind.\n"
"globe. When that day finally comes, as it will, the people of West Berlin can take " "Freedom is indivisible, and when one man is enslaved, all are not free. "
"sober satisfaction in the fact that they were in the front lines for almost two " "When all are free, then we can look forward to that day when this city "
"decades.\n" "will be joined as one and this country and this great Continent of "
"All free men, wherever they may live, are citizens of Berlin, and, therefore, " "Europe in a peaceful and hopeful globe. When that day finally comes, "
"as a free man, I take pride in the words \"Ich bin ein Berliner.\"\n" "as it will, the people of West Berlin can take sober satisfaction "
"in the fact that they were in the front lines for almost two decades.\n"
"All free men, wherever they may live, are citizens of Berlin, and, "
"therefore, as a free man, I take pride in the words "
"\"Ich bin ein Berliner.\"\n"
"President John F. Kennedy - June 26, 1963\n"; "President John F. Kennedy - June 26, 1963\n";
#endif #endif
@@ -200,10 +207,11 @@ int main(int argc, char **argv, char **envp)
return 1; return 1;
} }
tty.c_iflag &= ~(IGNBRK|BRKINT|PARMRK|ISTRIP|INLCR|IGNCR|ICRNL|IXON); tty.c_iflag &=
~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR | IGNCR | ICRNL | IXON);
tty.c_oflag &= ~OPOST; tty.c_oflag &= ~OPOST;
tty.c_lflag &= ~(ECHO|ECHONL|ICANON|ISIG|IEXTEN); tty.c_lflag &= ~(ECHO | ECHONL | ICANON | ISIG | IEXTEN);
tty.c_cflag &= ~(CSIZE|PARENB); tty.c_cflag &= ~(CSIZE | PARENB);
tty.c_cflag |= CS8; tty.c_cflag |= CS8;
ret = tcsetattr(fd, TCSANOW, &tty); ret = tcsetattr(fd, TCSANOW, &tty);
@@ -217,14 +225,14 @@ int main(int argc, char **argv, char **envp)
/* Wait for and/or send messages -- forever */ /* Wait for and/or send messages -- forever */
for (;;) for (; ; )
{ {
/* Test IN messages (device-to-host) */ /* Test IN messages (device-to-host) */
#ifndef CONFIG_EXAMPLES_USBSERIAL_OUTONLY #ifndef CONFIG_EXAMPLES_USBSERIAL_OUTONLY
printf("main: Reading from the serial driver\n"); printf("main: Reading from the serial driver\n");
printf("main: ... (Control-C to terminate) ...\n"); printf("main: ... (Control-C to terminate) ...\n");
nbytes = read(fd, g_iobuffer, BUFFER_SIZE-1); nbytes = read(fd, g_iobuffer, BUFFER_SIZE - 1);
if (nbytes < 0) if (nbytes < 0)
{ {
printf("main: ERROR: Failed to read from %s: %s\n", printf("main: ERROR: Failed to read from %s: %s\n",
@@ -249,7 +257,8 @@ int main(int argc, char **argv, char **envp)
/* Test OUT messages (host-to-device) */ /* Test OUT messages (host-to-device) */
#ifndef CONFIG_EXAMPLES_USBSERIAL_INONLY #ifndef CONFIG_EXAMPLES_USBSERIAL_INONLY
#if !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) && !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG) #if !defined(CONFIG_EXAMPLES_USBSERIAL_ONLYSMALL) && \
!defined(CONFIG_EXAMPLES_USBSERIAL_ONLYBIG)
count++; count++;
if (count < 5) if (count < 5)
{ {
@@ -276,7 +285,8 @@ int main(int argc, char **argv, char **envp)
if (nbytes < 0) if (nbytes < 0)
{ {
printf("main: ERROR: Failed to write to %s: %s\n", g_ttydev, strerror(errno)); printf("main: ERROR: Failed to write to %s: %s\n", g_ttydev,
strerror(errno));
close(fd); close(fd);
return 2; return 2;
} }