Manuel Pégourié-Gonnard
fc9cb1359f
Merge pull request #7030 from daverodgman/sizeof-brackets-2.28
...
Backport 2.28 - Sizeof brackets
2023-02-03 10:29:48 +01:00
Dave Rodgman
ecb44208d1
Address missed instances of sizeof
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
2023-02-02 15:34:23 +00:00
Dave Rodgman
1868870fba
Fix use of sizeof without brackets
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
2023-02-02 12:46:39 +00:00
Gilles Peskine
45379cbe6b
Merge pull request #7001 from ucko/2023a-bignum-2.28
...
[Backport 2.28] mbedtls_mpi_sub_abs: Skip memcpy when redundant (#6701 ).
2023-02-01 11:36:28 +01:00
Aaron M. Ucko
78b823ab0e
mbedtls_mpi_sub_abs: Skip memcpy when redundant ( #6701 ).
...
In some contexts, the output pointer may equal the first input
pointer, in which case copying is not only superfluous but results in
"Source and destination overlap in memcpy" errors from Valgrind (as I
observed in the context of ecp_double_jac) and a diagnostic message
from TrustInSoft Analyzer (as Pascal Cuoq reported in the context of
other ECP functions called by cert-app with a suitable certificate).
Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
2023-01-31 15:45:44 -05:00
Gilles Peskine
9a10538f20
Merge pull request #6965 from davidhorstmann-arm/2.28-code-style-improvements
...
[Backport 2.28] Improvements to code style script
2023-01-31 21:22:59 +01:00
Manuel Pégourié-Gonnard
4b7cb8c737
Merge pull request #6919 from valeriosetti/issue6843-backport
...
Backport: Improve X.509 cert writing serial number management
2023-01-30 13:09:09 +01:00
Manuel Pégourié-Gonnard
54be0fafc6
Merge pull request #6968 from aditya-deshpande-arm/backport-check-names-exclusions
...
[Backport 2.28] check_names.py: Compare identifiers in excluded files against symbols parsed by nm
2023-01-30 09:22:09 +01:00
Aditya Deshpande
7d20bb4740
Re-add empty lines that were accidentally omitted in the previous commit.
...
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
2023-01-27 16:03:22 +00:00
Manuel Pégourié-Gonnard
27276fcb97
Merge pull request #6844 from gilles-peskine-arm/test_suite_psa_crypto_metadata-20221215-2.28
...
Backport 2.28: Add metadata tests for CCM* and TLS1.2-ECJPAKE-to-PMS
2023-01-27 10:05:04 +01:00
Gilles Peskine
f57f3db920
Merge pull request #6931 from AndrzejKurek/timeless-selftest-waz-bad
...
[2.28] Enable the timing.c selftest with MBEDTLS_TIMING_ALT
2023-01-26 21:55:44 +01:00
Gilles Peskine
0f16ce0116
Merge pull request #6963 from davidhorstmann-arm/2.28-fix-check-python-errors
...
[Backport 2.28] Fix check python errors
2023-01-26 21:54:30 +01:00
Gilles Peskine
c2738f22b3
Merge pull request #6954 from gilles-peskine-arm/6658-not-print-Terminated-ubuntu-22.04-2.28
...
Backport 2.28: Fix the problem of printing "Terminated" in compat.sh under Ubuntu-22.04
2023-01-26 21:53:28 +01:00
Valerio Setti
7ba0037468
test: improve error handling in x509_set_serial_check()
...
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
2023-01-26 18:03:27 +01:00
Andrzej Kurek
26d383998d
Be consistent with self-test naming
...
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-26 04:38:37 -05:00
Andrzej Kurek
3a261a4dfd
Add a selftest run for the TIMING_ALT test
...
The fuzz programs require one layer of directories
more when adding include directories.
Also remove an unnecessary include directory in the Makefile.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-26 04:33:59 -05:00
Aditya Deshpande
94375c81f0
Update check_names.py so that identifiers in excluded files are still compared against the output of nm.
...
This fixes the issue where excluding a file containing identifiers from checks would cause check_symbols_in_header to fail.
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
2023-01-25 17:10:23 +00:00
David Horstmann
04aaa45ee1
Remove unnecessary '\' linebreak characters
...
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-25 11:39:45 +00:00
David Horstmann
659d905cf9
Give proper Dict type hints in crypto_knowledge.py
...
This prevents a return type error in a later function that uses the
dictionaries here properly typed.
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 19:01:31 +00:00
David Horstmann
4fc7e0ed62
Fix a missing type hint warning
...
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 19:01:31 +00:00
David Horstmann
6956cb58ac
Don't wrap stdout and stderr in UTF-8 wrapper
...
This is no longer needed as we only print ASCII text directly
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 18:43:12 +00:00
David Horstmann
5682e80266
Output diff without capturing it
...
Instead of capturing the output of diff and printing it, let diff do its
own outputting and se the return code to decide what to do.
This also means that the conversion of stdout to UTF-8 is not necessary,
as the reason it was needed was for printing diffs of files with UTF-8
characters in them.
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 18:43:12 +00:00
David Horstmann
6d02f0cfa0
Add basic output on success
...
Whilst it is true that "silence is golden", no output at all could be
disconcerting and it makes searching in a CI log more difficult.
Add a simple status message that says "Checked N files, style ok".
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 18:43:12 +00:00
David Horstmann
3febe15114
Remove overly verbose output on success
...
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 18:43:12 +00:00
David Horstmann
64827e4611
Change print to print_err for an error message
...
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 18:43:12 +00:00
David Horstmann
71ccdaacd1
Remove unnecessary "Line length options" heading
...
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 18:43:12 +00:00
David Horstmann
a27d872228
Document that the script must be run from the root
...
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 18:43:12 +00:00
David Horstmann
f7b7bf7a5e
Remove provisional notice on code style script
...
Since code style is now enforced, the notice is wrong. Remove it to
avoid confusion.
Signed-off-by: David Horstmann <david.horstmann@arm.com>
2023-01-24 18:43:12 +00:00
Dave Rodgman
8431fe05f1
Merge pull request #6953 from daverodgman/getting-started-2.28
...
Backport 2.28 - Getting started
2023-01-24 10:25:45 +00:00
Manuel Pégourié-Gonnard
85f65f8f2f
Merge pull request #6944 from AndrzejKurek/2.28-depends-py-kex-fixes
...
[Backport 2.28] Depends.py - add exclusive domain tests to key exchange testing
2023-01-24 09:32:09 +01:00
Dave Rodgman
385c81a2d3
Minor fixes
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
2023-01-23 12:35:45 +00:00
Dave Rodgman
aefb5e1211
Fix some additional over-long lines
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
2023-01-23 12:35:40 +00:00
Andrzej Kurek
ddf6260aae
Remove obsolete comment from depends.py
...
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-23 06:19:14 -05:00
Dave Rodgman
2cf3c83bf1
Merge pull request #6951 from daverodgman/fix-rsaalt-test-guards-2.28
2023-01-20 18:29:01 +00:00
Yanray Wang
2a7b2a6a9d
Redirect stdout/stderr to SRV_OUT
...
Under Ubuntu-22.04, wait command prints out Terminated message.
Therefore server process is handled with identical ways like other
processes in compat.sh. In addition, PROCESS_ID is renamed as
SRV_PID to improve code readability.
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
2023-01-20 15:51:25 +01:00
Yanray Wang
d2ad200ff9
Remove Terminated message from stdout
...
Under Ubuntu-22.04, wait command prints out Terminated message
if the process has been killed by kill command. This messes up
the output in compat.sh
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
2023-01-20 15:51:23 +01:00
Dave Rodgman
5fce4f6a45
Add regression test
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
2023-01-20 13:24:01 +00:00
Dave Rodgman
339730091a
Update the getting-started doc
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
2023-01-20 12:48:35 +00:00
Dave Rodgman
6b8d42444d
Add Changelog
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
2023-01-20 11:43:01 +00:00
Dave Rodgman
bd2b8e4e6a
Fix test guards
...
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
2023-01-20 11:42:54 +00:00
Andrzej Kurek
15a3f1d0b8
Add missing key exchange requirements to test_suite_ssl
...
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-19 17:12:38 -05:00
Andrzej Kurek
cbb34b9e22
Add missing KEX DHE-RSA requirement for one ssl test
...
This specific cipher is used to test record splitting.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-19 15:19:52 -05:00
Andrzej Kurek
eeb8624f2d
Add missing RSA-type dependencies in test_suite_ssl
...
These are not run in development because of the overlapping
!TLS_1_3 requirement and usage of full config.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-19 15:18:35 -05:00
Andrzej Kurek
01bdab3e30
Add missing key exchange requirements to test_suite_ssl
...
Some of the tests use mbedtls_test_cli_key_rsa_der and
mbedtls_test_cli_crt_rsa_der, and these can be used with
specific ciphersuites.
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-19 15:18:00 -05:00
Gilles Peskine
1d671c90db
Merge pull request #6835 from gilles-peskine-arm/code-style-files-2.28
...
Backport 2.28: code_style.py: Support restyling only the specified files
2023-01-19 12:26:07 +01:00
Gilles Peskine
b71d28b695
Fix example command
...
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
2023-01-17 18:09:39 +00:00
Andrzej Kurek
de416fc2c6
depends.py: enable key exchange tests
...
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-17 10:40:28 -05:00
Andrzej Kurek
4136a9ec5a
Shorten lines of changelog entry
...
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-17 06:09:37 -05:00
Andrzej Kurek
721cff1a89
Fix a copy-paste error in define comment
...
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-17 05:44:06 -05:00
Andrzej Kurek
b36fa910e9
Add a changelog entry
...
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
2023-01-17 05:28:25 -05:00